Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Unified Diff: tests/compiler/dart2js/type_test_helper.dart

Issue 12393039: Add type presentation for function types. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Rebased Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/compiler/dart2js/type_representation_test.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/compiler/dart2js/type_test_helper.dart
diff --git a/tests/compiler/dart2js/type_test_helper.dart b/tests/compiler/dart2js/type_test_helper.dart
index 94faaced6fc73d986ecabb64dd008ee8fa42094c..586af02dd82487f418aa79f93fa667164a1df96b 100644
--- a/tests/compiler/dart2js/type_test_helper.dart
+++ b/tests/compiler/dart2js/type_test_helper.dart
@@ -5,10 +5,17 @@
library type_test_helper;
import '../../../sdk/lib/_internal/compiler/implementation/dart_types.dart';
+import "parser_helper.dart" show SourceString;
import "compiler_helper.dart";
-InterfaceType instantiate(ClassElement element, List<DartType> arguments) {
- return new InterfaceType(element, new Link<DartType>.fromList(arguments));
+GenericType instantiate(TypeDeclarationElement element,
+ List<DartType> arguments) {
+ if (element.isClass()) {
+ return new InterfaceType(element, new Link<DartType>.fromList(arguments));
+ } else {
+ assert(element.isTypedef());
+ return new TypedefType(element, new Link<DartType>.fromList(arguments));
+ }
}
class TypeEnvironment {
@@ -29,8 +36,10 @@ class TypeEnvironment {
Element getElement(String name) {
var element = findElement(compiler, name);
Expect.isNotNull(element);
- if (identical(element.kind, ElementKind.CLASS)) {
+ if (element.isClass()) {
element.ensureResolved(compiler);
+ } else if (element.isTypedef()) {
+ element.computeType(compiler);
}
return element;
}
@@ -44,7 +53,35 @@ class TypeEnvironment {
return getElementType(name);
}
+ DartType getMemberType(ClassElement element, String name) {
+ Element member = element.localLookup(new SourceString(name));
+ return member.computeType(compiler);
+ }
+
bool isSubtype(DartType T, DartType S) {
return compiler.types.isSubtype(T, S);
}
+
+ FunctionType functionType(DartType returnType,
+ List<DartType> parameters,
+ {List<DartType> optionalParameter,
+ Map<String,DartType> namedParameters}) {
+ Link<DartType> parameterTypes =
+ new Link<DartType>.fromList(parameters);
+ Link<DartType> optionalParameterTypes = optionalParameter != null
+ ? new Link<DartType>.fromList(optionalParameter)
+ : const Link<DartType>();
+ var namedParameterNames = new LinkBuilder<SourceString>();
+ var namedParameterTypes = new LinkBuilder<DartType>();
+ if (namedParameters != null) {
+ namedParameters.forEach((String name, DartType type) {
+ namedParameterNames.addLast(new SourceString(name));
+ namedParameterTypes.addLast(type);
+ });
+ }
+ FunctionType type = new FunctionType(
+ compiler.functionClass,
+ returnType, parameterTypes, optionalParameterTypes,
+ namedParameterNames.toLink(), namedParameterTypes.toLink());
+ }
}
« no previous file with comments | « tests/compiler/dart2js/type_representation_test.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698