Check if enclosingElement is null.

Check if enclosingElement is null.

R=ngeoffray@google.com

Committed: https://code.google.com/p/dart/source/detail?r=19287

[karlklose, 2013-03-01 09:47:39]

Committed patchset #1 manually as r19287 (presubmit successful).

[karlklose, 2013-03-01 09:48:06]

TBR'ed to fix the build.

[ngeoffray, 2013-03-01 09:49:18]

LGTM, but

https://codereview.chromium.org/12393004/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/resolution/members.dart (right):

https://codereview.chromium.org/12393004/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/resolution/members.dart:1640:
inCheckContext = compiler.enableTypeAssertions &&
Comment?

https://codereview.chromium.org/12393004/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/resolution/members.dart:1642:
!element.enclosingElement.isTypedef()),
So we're creating a ResolverVisitor for things contained in a Typedef? What are
those? Parameters, type parameters? This looks kind of odd.

[ahe, 2013-03-01 09:54:36]

DBC

https://codereview.chromium.org/12393004/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/resolution/members.dart (right):

https://codereview.chromium.org/12393004/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/resolution/members.dart:1642:
!element.enclosingElement.isTypedef()),
On 2013/03/01 09:49:18, ngeoffray wrote:
> So we're creating a ResolverVisitor for things contained in a Typedef? What
are
> those? Parameters, type parameters? This looks kind of odd.

I'm also confused about this. This fix does not look right to me.

[karlklose, 2013-03-01 10:21:44]

https://codereview.chromium.org/12393004/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/resolution/members.dart (right):

https://codereview.chromium.org/12393004/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/resolution/members.dart:1640:
inCheckContext = compiler.enableTypeAssertions &&
Created a CL.

https://codereview.chromium.org/12393004/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/resolution/members.dart:1642:
!element.enclosingElement.isTypedef()),
When the signature resolver asks the VariableListElement of the typdef for its
type, the creates a ResolverVisitor to call resolveReturnType.

[ahe, 2013-03-12 08:15:40]

https://codereview.chromium.org/12393004/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/resolution/members.dart (right):

https://codereview.chromium.org/12393004/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/resolution/members.dart:1642:
!element.enclosingElement.isTypedef()),
On 2013/03/01 10:21:44, karlklose wrote:
> When the signature resolver asks the VariableListElement of the typdef for its
> type, the creates a ResolverVisitor to call resolveReturnType.

That does not explain why you have an element that does not have an enclosing
element here.