Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Unified Diff: sdk/lib/_internal/compiler/implementation/resolution/members.dart

Issue 12393004: Check if enclosingElement is null. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/_internal/compiler/implementation/resolution/members.dart
diff --git a/sdk/lib/_internal/compiler/implementation/resolution/members.dart b/sdk/lib/_internal/compiler/implementation/resolution/members.dart
index 7f8681001974c2c19c425430c9b2b16ec3883260..beb5348e2875c8c23cc21129ef64476cb6a85ef3 100644
--- a/sdk/lib/_internal/compiler/implementation/resolution/members.dart
+++ b/sdk/lib/_internal/compiler/implementation/resolution/members.dart
@@ -1638,7 +1638,8 @@ class ResolverVisitor extends CommonResolverVisitor<Element> {
typeResolver = new TypeResolver(compiler),
scope = element.buildScope(),
inCheckContext = compiler.enableTypeAssertions &&
ngeoffray 2013/03/01 09:49:18 Comment?
karlklose 2013/03/01 10:21:44 Created a CL.
- !element.enclosingElement.isTypedef(),
+ (element.enclosingElement == null ||
+ !element.enclosingElement.isTypedef()),
ngeoffray 2013/03/01 09:49:18 So we're creating a ResolverVisitor for things con
ahe 2013/03/01 09:54:36 I'm also confused about this. This fix does not lo
karlklose 2013/03/01 10:21:44 When the signature resolver asks the VariableListE
ahe 2013/03/12 08:15:40 That does not explain why you have an element that
inCatchBlock = false,
super(compiler);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698