Infer types of catpured variables and use the types in the SSA builder.

Infer types of catpured variables and use the types in the SSA builder.
Committed: https://code.google.com/p/dart/source/detail?r=19455

[kasperl, 2013-03-05 08:26:44]

LGTM.

https://codereview.chromium.org/12385076/diff/17/sdk/lib/_internal/compiler/i...
File sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart
(right):

https://codereview.chromium.org/12385076/diff/17/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart:832:
// a previous closure. Note that analyzing multiple times the same
analyzing multiple times the same closure -> analyzing the same closure multiple
times

https://codereview.chromium.org/12385076/diff/17/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart:1125:
// This only works for function statements. We need a
How do you know element is introduced through a function statement? I'm not sure
I fully understand the comment. It sounds like the code here is broken if
element doesn't originate from a function statement, but you do not check for
anything. Is the point that returnTypeOfElement returns dynamic if passed an
element for a function expression?

https://codereview.chromium.org/12385076/diff/17/sdk/lib/_internal/compiler/i...
File sdk/lib/_internal/compiler/implementation/types/types.dart (right):

https://codereview.chromium.org/12385076/diff/17/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/types/types.dart:110: ConcreteType
guaranteedType = typesInferrer
Can you move typesInferrer to the next line too?

https://codereview.chromium.org/12385076/diff/17/tests/compiler/dart2js/simpl...
File tests/compiler/dart2js/simple_inferrer_closure_test.dart (right):

https://codereview.chromium.org/12385076/diff/17/tests/compiler/dart2js/simpl...
tests/compiler/dart2js/simple_inferrer_closure_test.dart:93: // TODO(ngeoffray):
We don't use types of mutated captured
So you'd like to fix this to make returnInt2 return an int? I guess so.

https://codereview.chromium.org/12385076/diff/17/tests/compiler/dart2js/types...
File tests/compiler/dart2js/types_of_captured_variables_test.dart (right):

https://codereview.chromium.org/12385076/diff/17/tests/compiler/dart2js/types...
tests/compiler/dart2js/types_of_captured_variables_test.dart:10: var f = () => a
+ 3;
Is this different than 

   f() => a + 3;

[ngeoffray, 2013-03-05 09:02:31]

Thanks Kasper.

https://codereview.chromium.org/12385076/diff/17/sdk/lib/_internal/compiler/i...
File sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart
(right):

https://codereview.chromium.org/12385076/diff/17/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart:832:
// a previous closure. Note that analyzing multiple times the same
On 2013/03/05 08:26:44, kasperl wrote:
> analyzing multiple times the same closure -> analyzing the same closure
multiple
> times

Done.

https://codereview.chromium.org/12385076/diff/17/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart:1125:
// This only works for function statements. We need a
On 2013/03/05 08:26:44, kasperl wrote:
> How do you know element is introduced through a function statement? I'm not
sure
> I fully understand the comment. It sounds like the code here is broken if
> element doesn't originate from a function statement, but you do not check for
> anything. Is the point that returnTypeOfElement returns dynamic if passed an
> element for a function expression?

Being a closure send, we know that if element is not null, it is a local (see
Elements.isClosureSend). I added an assert that [element] is local.

https://codereview.chromium.org/12385076/diff/17/sdk/lib/_internal/compiler/i...
File sdk/lib/_internal/compiler/implementation/types/types.dart (right):

https://codereview.chromium.org/12385076/diff/17/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/types/types.dart:110: ConcreteType
guaranteedType = typesInferrer
On 2013/03/05 08:26:44, kasperl wrote:
> Can you move typesInferrer to the next line too?

Done.

https://codereview.chromium.org/12385076/diff/17/tests/compiler/dart2js/simpl...
File tests/compiler/dart2js/simple_inferrer_closure_test.dart (right):

https://codereview.chromium.org/12385076/diff/17/tests/compiler/dart2js/simpl...
tests/compiler/dart2js/simple_inferrer_closure_test.dart:93: // TODO(ngeoffray):
We don't use types of mutated captured
On 2013/03/05 08:26:44, kasperl wrote:
> So you'd like to fix this to make returnInt2 return an int? I guess so.

Depends on the TODO I added in the types inferrer: once we definitely know the
type of a mutated variable, should we re-analyze the method?

I guess this should not blow up analysis time, mutated variables in closures are
very local, and does not involve re-analyzing a lot of methods.

https://codereview.chromium.org/12385076/diff/17/tests/compiler/dart2js/types...
File tests/compiler/dart2js/types_of_captured_variables_test.dart (right):

https://codereview.chromium.org/12385076/diff/17/tests/compiler/dart2js/types...
tests/compiler/dart2js/types_of_captured_variables_test.dart:10: var f = () => a
+ 3;
On 2013/03/05 08:26:44, kasperl wrote:
> Is this different than 
> 
>    f() => a + 3;

Not for the analysis.

[ngeoffray, 2013-03-05 09:45:57]

Committed patchset #2 manually as r19455 (presubmit successful).

[karlklose, 2013-03-05 09:57:24]

https://codereview.chromium.org/12385076/diff/15001/sdk/lib/_internal/compile...
File sdk/lib/_internal/compiler/implementation/closure.dart (right):

https://codereview.chromium.org/12385076/diff/15001/sdk/lib/_internal/compile...
sdk/lib/_internal/compiler/implementation/closure.dart:212: void
forEachBoxedVariable(void f(Element element)) {
Is this function used?

[ngeoffray, 2013-03-05 10:18:45]

https://codereview.chromium.org/12385076/diff/15001/sdk/lib/_internal/compile...
File sdk/lib/_internal/compiler/implementation/closure.dart (right):

https://codereview.chromium.org/12385076/diff/15001/sdk/lib/_internal/compile...
sdk/lib/_internal/compiler/implementation/closure.dart:212: void
forEachBoxedVariable(void f(Element element)) {
On 2013/03/05 09:57:24, karlklose wrote:
> Is this function used?

No, but I'd like to come up with some abstractions on top of the closure data.
Users of closure data are looking into its fields, and it does not help
readability.