sdk/lib/_internal/compiler/implementation/ssa/types_propagation.dart - Issue 12385076: Infer types of catpured variables and use the types in the SSA builder.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/ssa/types_propagation.dart

Issue 12385076: Infer types of catpured variables and use the types in the SSA builder. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« sdk/lib/_internal/compiler/implementation/closure.dart ('K') | « sdk/lib/_internal/compiler/implementation/ssa/types.dart ('k') | sdk/lib/_internal/compiler/implementation/types/concrete_types_inferrer.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/ssa/types_propagation.dart

===================================================================

--- sdk/lib/_internal/compiler/implementation/ssa/types_propagation.dart (revision 19427)

+++ sdk/lib/_internal/compiler/implementation/ssa/types_propagation.dart (working copy)

@@ -135,9 +135,14 @@

HType type = HType.CONFLICTING;

DartType functionType = compiler.functionClass.computeType(compiler);

for (Element each in compiler.world.allFunctions.filter(refined)) {

- HType inferred = (refined.isGetter() && each.isFunction())

- ? new HType.nonNullExact(functionType, compiler)

- : new HType.inferredForElement(each, compiler);

+ HType inferred;

+ if (refined.isGetter() && each.isFunction()) {

+ inferred = new HType.nonNullExact(functionType, compiler);

+ } else if (refined.isGetter() && each.isField()) {

+ inferred = new HType.inferredTypeForElement(each, compiler);

+ } else {

+ inferred = new HType.inferredReturnTypeForElement(each, compiler);

+ }

type = type.union(inferred, compiler);

if (type.isUnknown()) break;

}