Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 12382031: Make pub warning-clean. (Closed)

Created:
7 years, 9 months ago by nweiz
Modified:
7 years, 9 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Make pub warning-clean. Committed: https://code.google.com/p/dart/source/detail?r=19265

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -32 lines) Patch
M utils/pub/io.dart View 3 chunks +4 lines, -4 lines 0 comments Download
M utils/pub/log.dart View 1 chunk +6 lines, -6 lines 0 comments Download
M utils/pub/utils.dart View 3 chunks +8 lines, -8 lines 0 comments Download
M utils/pub/validator/name.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M utils/pub/version_solver.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M utils/tests/pub/command_line_config.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M utils/tests/pub/pub.status View 1 chunk +1 line, -1 line 0 comments Download
M utils/tests/pub/test_pub.dart View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
nweiz
7 years, 9 months ago (2013-02-28 23:11:30 UTC) #1
Bob Nystrom
lgtm
7 years, 9 months ago (2013-02-28 23:14:16 UTC) #2
nweiz
7 years, 9 months ago (2013-02-28 23:22:06 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r19265 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698