Issue 12378039: Inline ByteArray setters like setUint8 in the optimizer.

Issue 12378039: Inline ByteArray setters like setUint8 in the optimizer. (Closed)

Created:
7 years, 9 months ago by Florian Schneider

Modified:
7 years, 9 months ago

Reviewers:
Vyacheslav Egorov (Google)

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Inline ByteArray setters like setUint8 in the optimizer. Committed: https://code.google.com/p/dart/source/detail?r=19781

Patch Set 3 : addressed comments #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+212 lines, -92 lines)			Patch
M	runtime/vm/flow_graph_builder.cc	View	1	2 chunks	+3 lines, -1 line	0 comments	Download
M	runtime/vm/flow_graph_optimizer.h	View	1	1 chunk	+9 lines, -3 lines	0 comments	Download
M	runtime/vm/flow_graph_optimizer.cc	View	1 2	8 chunks	+168 lines, -58 lines	0 comments	Download
M	runtime/vm/intermediate_language.h	View	1	5 chunks	+15 lines, -3 lines	0 comments	Download
M	runtime/vm/intermediate_language_ia32.cc	View	1	4 chunks	+9 lines, -14 lines	0 comments	Download
M	runtime/vm/intermediate_language_x64.cc	View	1	4 chunks	+8 lines, -13 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Vyacheslav Egorov (Google)

lgtm https://codereview.chromium.org/12378039/diff/7001/runtime/vm/flow_graph_optimizer.cc File runtime/vm/flow_graph_optimizer.cc (right): https://codereview.chromium.org/12378039/diff/7001/runtime/vm/flow_graph_optimizer.cc#newcode765 runtime/vm/flow_graph_optimizer.cc:765: if ((kSmiBits < 32) && !FlowGraphCompiler::SupportsUnboxedMints()) { I ...

7 years, 9 months ago (2013-03-11 11:45:27 UTC) #2

Florian Schneider

https://codereview.chromium.org/12378039/diff/7001/runtime/vm/flow_graph_optimizer.cc File runtime/vm/flow_graph_optimizer.cc (right): https://codereview.chromium.org/12378039/diff/7001/runtime/vm/flow_graph_optimizer.cc#newcode765 runtime/vm/flow_graph_optimizer.cc:765: if ((kSmiBits < 32) && !FlowGraphCompiler::SupportsUnboxedMints()) { On 2013/03/11 ...

7 years, 9 months ago (2013-03-11 12:14:12 UTC) #3

Florian Schneider

7 years, 9 months ago (2013-03-11 12:17:04 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r19781 (presubmit successful).

Expand Messages | Collapse Messages