runtime/vm/flow_graph_optimizer.h - Issue 12378039: Inline ByteArray setters like setUint8 in the optimizer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/flow_graph_optimizer.h

Issue 12378039: Inline ByteArray setters like setUint8 in the optimizer. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: addressed comments Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/flow_graph_optimizer.h

===================================================================

--- runtime/vm/flow_graph_optimizer.h (revision 19765)

+++ runtime/vm/flow_graph_optimizer.h (working copy)

@@ -87,9 +87,15 @@

LoadIndexedInstr* BuildStringCodeUnitAt(InstanceCallInstr* call,

intptr_t cid);

- LoadIndexedInstr* BuildByteArrayViewLoad(InstanceCallInstr* call,

- intptr_t receiver_cid,

- intptr_t view_cid);

+ bool BuildByteArrayViewLoad(InstanceCallInstr* call,

+ intptr_t receiver_cid,

+ intptr_t view_cid);

+ bool BuildByteArrayViewStore(InstanceCallInstr* call,

+ intptr_t receiver_cid,

+ intptr_t view_cid);

+ void PrepareByteArrayViewOp(InstanceCallInstr* call,

+ intptr_t receiver_cid,

+ intptr_t view_cid);

// Insert a check of 'to_check' determined by 'unary_checks'. If the

// check fails it will deoptimize to 'deopt_id' using the deoptimization

« no previous file with comments | « runtime/vm/flow_graph_builder.cc ('k') | runtime/vm/flow_graph_optimizer.cc » ('j') | no next file with comments »