Fix factory name to result cid mapping, run type propagation once more after constant propagation.

Fix factory name to result cid mapping, run type propagation once more after constant propagation.
Committed: https://code.google.com/p/dart/source/detail?r=19256

[Vyacheslav Egorov (Google), 2013-02-28 20:37:51]

lgtm

https://codereview.chromium.org/12374024/diff/2002/runtime/vm/flow_graph_type...
File runtime/vm/flow_graph_type_propagator.cc (left):

https://codereview.chromium.org/12374024/diff/2002/runtime/vm/flow_graph_type...
runtime/vm/flow_graph_type_propagator.cc:56:
ASSERT(worklist_[i]->Type()->IsNone());
For the best result I suggest resetting all phis back to None, in this case the
type propagation will happen across cycles of phis. 

Simplest example:

var a = new List(n);  // v1
while (true) {  // v2 = phi(v1, v4)
  if (smth) {
    a = new List(n);  // v3
  }
  // v4 = phi (v2, v3)
}

in this case v2 will stay DynamicType because it uses phi that is still
DynamicType and so on.

So instead remove #ifdef and

  // Initially the worklist contains only phis.
  // Reset compile type of all phis to None to ensure that
  // types are correctly propagated through the cycles of
  // phis.
  for (intptr_t i = 0; i < worklist_.length(); i++) {
    ASSERT(worklist_[i]->IsPhi());
    *worklist_[i]->Type() = CompileType::None();
  }

[siva, 2013-02-28 20:49:36]

lgtm

[srdjan, 2013-02-28 20:52:46]

https://codereview.chromium.org/12374024/diff/2002/runtime/vm/flow_graph_type...
File runtime/vm/flow_graph_type_propagator.cc (left):

https://codereview.chromium.org/12374024/diff/2002/runtime/vm/flow_graph_type...
runtime/vm/flow_graph_type_propagator.cc:56:
ASSERT(worklist_[i]->Type()->IsNone());
On 2013/02/28 20:37:52, Vyacheslav Egorov (Google) wrote:
> For the best result I suggest resetting all phis back to None, in this case
the
> type propagation will happen across cycles of phis. 
> 
> Simplest example:
> 
> var a = new List(n);  // v1
> while (true) {  // v2 = phi(v1, v4)
>   if (smth) {
>     a = new List(n);  // v3
>   }
>   // v4 = phi (v2, v3)
> }
> 
> in this case v2 will stay DynamicType because it uses phi that is still
> DynamicType and so on.
> 
> So instead remove #ifdef and
> 
>   // Initially the worklist contains only phis.
>   // Reset compile type of all phis to None to ensure that
>   // types are correctly propagated through the cycles of
>   // phis.
>   for (intptr_t i = 0; i < worklist_.length(); i++) {
>     ASSERT(worklist_[i]->IsPhi());
>     *worklist_[i]->Type() = CompileType::None();
>   }

Thanks, done.

[srdjan, 2013-02-28 20:54:24]

Committed patchset #3 manually as r19256 (presubmit successful).