Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Unified Diff: runtime/vm/flow_graph_type_propagator.cc

Issue 12374024: Fix factory name to result cid mapping, run type propagation once more after constant propagation. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/flow_graph_builder.cc ('k') | runtime/vm/symbols.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/flow_graph_type_propagator.cc
===================================================================
--- runtime/vm/flow_graph_type_propagator.cc (revision 19253)
+++ runtime/vm/flow_graph_type_propagator.cc (working copy)
@@ -49,13 +49,14 @@
// Collect all phis for a fixed point iteration.
PropagateRecursive(flow_graph_->graph_entry());
-#ifdef DEBUG
// Initially the worklist contains only phis.
+ // Reset compile type of all phis to None to ensure that
+ // types are correctly propagated through the cycles of
+ // phis.
for (intptr_t i = 0; i < worklist_.length(); i++) {
ASSERT(worklist_[i]->IsPhi());
- ASSERT(worklist_[i]->Type()->IsNone());
+ *worklist_[i]->Type() = CompileType::None();
}
-#endif
// Iterate until a fixed point is reached, updating the types of
// definitions.
« no previous file with comments | « runtime/vm/flow_graph_builder.cc ('k') | runtime/vm/symbols.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698