Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(465)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1237203002: Insert debug step check at the beginning of a function. (Closed)

Created:
5 years, 5 months ago by rmacnak
Modified:
5 years, 5 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, turnidge, Cutch, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Insert debug step check at the beginning of a function. BUG=http://dartbug.com/23827 R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/c165fee6114db11b4c717770b06342cdcd2a301b

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -18 lines) Patch
A runtime/observatory/tests/service/break_on_function_test.dart View 1 chunk +72 lines, -0 lines 0 comments Download
M runtime/observatory/tests/service/debugging_test.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M runtime/observatory/tests/service/eval_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/observatory/tests/service/test_helper.dart View 1 chunk +3 lines, -1 line 0 comments Download
M runtime/vm/debugger_api_impl_test.cc View 1 chunk +15 lines, -11 lines 0 comments Download
M runtime/vm/flow_graph_builder.cc View 1 chunk +5 lines, -0 lines 2 comments Download
M tests/standalone/debugger/break_at_equals_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
rmacnak
5 years, 5 months ago (2015-07-14 18:37:22 UTC) #2
Cutch
lgtm https://chromiumcodereview.appspot.com/1237203002/diff/1/runtime/vm/flow_graph_builder.cc File runtime/vm/flow_graph_builder.cc (right): https://chromiumcodereview.appspot.com/1237203002/diff/1/runtime/vm/flow_graph_builder.cc#newcode4202 runtime/vm/flow_graph_builder.cc:4202: AddInstruction(new(Z) DebugStepCheckInstr(function.token_pos(), I wonder if you could insert ...
5 years, 5 months ago (2015-07-14 19:54:37 UTC) #3
rmacnak
Committed patchset #1 (id:1) manually as c165fee6114db11b4c717770b06342cdcd2a301b (presubmit successful).
5 years, 5 months ago (2015-07-14 22:27:50 UTC) #4
rmacnak
5 years, 5 months ago (2015-07-14 22:28:29 UTC) #5
Message was sent while issue was closed. 
https://chromiumcodereview.appspot.com/1237203002/diff/1/runtime/vm/flow_grap...
File runtime/vm/flow_graph_builder.cc (right):

https://chromiumcodereview.appspot.com/1237203002/diff/1/runtime/vm/flow_grap...
runtime/vm/flow_graph_builder.cc:4202: AddInstruction(new(Z)
DebugStepCheckInstr(function.token_pos(),
On 2015/07/14 19:54:36, Cutch wrote:
> I wonder if you could insert this after the GraphcEntryInstr?

We don't seem to have the right things in scope to easily add it right where the
GraphEntry is constructed.

Powered by Google App Engine
This is Rietveld 408576698