Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Issue 1236013003: Fixed bug in implicit analysis notification and renamed tests (Closed)

Created:
5 years, 5 months ago by Brian Wilkerson
Modified:
5 years, 5 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fixed bug in implicit analysis notification and renamed tests R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/d37ac8d4d0774dc72235e484c65164689d1503ba

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -36 lines) Patch
M pkg/analyzer/lib/src/context/context.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/engine.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/generated/engine_test.dart View 2 chunks +15 lines, -15 lines 0 comments Download
M pkg/analyzer/test/src/context/context_test.dart View 3 chunks +19 lines, -19 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Brian Wilkerson
5 years, 5 months ago (2015-07-17 19:29:31 UTC) #2
scheglov
LGTM
5 years, 5 months ago (2015-07-17 19:36:17 UTC) #3
Brian Wilkerson
5 years, 5 months ago (2015-07-17 19:44:04 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d37ac8d4d0774dc72235e484c65164689d1503ba (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698