Fixed bug in implicit analysis notification and renamed tests

pkg/analyzer/test/src/context/context_test.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library test.src.context.context_test;
 
 import 'dart:async';
 
 import 'package:analyzer/file_system/memory_file_system.dart';
 import 'package:analyzer/src/cancelable_future.dart';
@@ skipping 37 matching lines @@
 import 'abstract_context.dart';
 
 main() {
   groupSep = ' | ';
   runReflectiveTests(AnalysisContextImplTest);
   runReflectiveTests(LimitedInvalidateTest);
 }
 
 @reflectiveTest
 class AnalysisContextImplTest extends AbstractContextTest {
-  Future fail_analyzedSources_removed() async {
+  Future fail_implicitAnalysisEvents_removed() async {
     AnalyzedSourcesListener listener = new AnalyzedSourcesListener();
     context.implicitAnalysisEvents.listen(listener.onData);
     //
     // Create a file that references an file that is not explicitly being
     // analyzed and fully analyze it. Ensure that the listener is told about
     // the implicitly analyzed file.
     //
     Source sourceA = newSource('/a.dart', "library a; import 'b.dart';");
     Source sourceB = newSource('/b.dart', "library b;");
     ChangeSet changeSet = new ChangeSet();
@@ skipping 40 matching lines @@
     fail("Implement this");
   }
 
   @override
   void tearDown() {
     context = null;
     sourceFactory = null;
     super.tearDown();
   }
 
-  Future test_analyzedSources_added() async {
-    AnalyzedSourcesListener listener = new AnalyzedSourcesListener();
-    context.implicitAnalysisEvents.listen(listener.onData);
-    //
-    // Create a file that references an file that is not explicitly being
-    // analyzed and fully analyze it. Ensure that the listener is told about
-    // the implicitly analyzed file.
-    //
-    Source sourceA = newSource('/a.dart', "library a; import 'b.dart';");
-    Source sourceB = newSource('/b.dart', "library b;");
-    ChangeSet changeSet = new ChangeSet();
-    changeSet.addedSource(sourceA);
-    context.applyChanges(changeSet);
-    context.computeErrors(sourceA);
-    await pumpEventQueue();
-    listener.expectAnalyzed(sourceB);
-  }
-
   Future test_applyChanges_add() {
     SourcesChangedListener listener = new SourcesChangedListener();
     context.onSourcesChanged.listen(listener.onData);
     expect(context.sourcesNeedingProcessing, isEmpty);
     Source source = newSource('/test.dart');
     ChangeSet changeSet = new ChangeSet();
     changeSet.addedSource(source);
     context.applyChanges(changeSet);
     expect(context.sourcesNeedingProcessing, contains(source));
     return pumpEventQueue().then((_) {
@@ skipping 1096 matching lines @@
     _analyzeAll_assertFinished();
     expect(context.getResolvedCompilationUnit2(source, source), isNotNull);
     // new contents
     contentCache.setContents(source, newContents);
     context.handleContentsChanged(source, oldContents, newContents, true);
     // there is some work to do
     AnalysisResult analysisResult = context.performAnalysisTask();
     expect(analysisResult.changeNotices, isNotNull);
   }
 
+  Future test_implicitAnalysisEvents_added() async {
+    AnalyzedSourcesListener listener = new AnalyzedSourcesListener();
+    context.implicitAnalysisEvents.listen(listener.onData);
+    //
+    // Create a file that references an file that is not explicitly being
+    // analyzed and fully analyze it. Ensure that the listener is told about
+    // the implicitly analyzed file.
+    //
+    Source sourceA = newSource('/a.dart', "library a; import 'b.dart';");
+    Source sourceB = newSource('/b.dart', "library b;");
+    ChangeSet changeSet = new ChangeSet();
+    changeSet.addedSource(sourceA);
+    context.applyChanges(changeSet);
+    context.computeErrors(sourceA);
+    await pumpEventQueue();
+    listener.expectAnalyzed(sourceB);
+  }
+
   void test_isClientLibrary_dart() {
     Source source = addSource("/test.dart", r'''
 import 'dart:html';
 
 main() {}''');
     expect(context.isClientLibrary(source), isFalse);
     expect(context.isServerLibrary(source), isFalse);
     context.computeLibraryElement(source);
     expect(context.isClientLibrary(source), isTrue);
     expect(context.isServerLibrary(source), isFalse);
@@ skipping 1087 matching lines @@
   }
 }
 
 class _AnalysisContextImplTest_test_applyChanges_removeContainer
     implements SourceContainer {
   Source libB;
   _AnalysisContextImplTest_test_applyChanges_removeContainer(this.libB);
   @override
   bool contains(Source source) => source == libB;
 }