Issue 12335146: - Do not use the ? operator in the List factory.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12335146: - Do not use the ? operator in the List factory. (Closed)

Created:
7 years, 9 months ago by Ivan Posva

Modified:
7 years, 9 months ago

Reviewers:
srdjan

CC:
reviews_dartlang.org, Lasse Reichstein Nielsen, Vyacheslav Egorov (Google), floitsch

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

- Do not use the ? operator in the List factory. Committed: https://code.google.com/p/dart/source/detail?r=19178

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+35 lines, -26 lines)			Patch
M	runtime/lib/array.cc	View	1 chunk	+14 lines, -5 lines	0 comments	Download
M	runtime/lib/array.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/lib/array_patch.dart	View	2 chunks	+17 lines, -17 lines	0 comments	Download
M	runtime/vm/intrinsifier.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/object.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Total messages: 3 (0 generated)

Ivan Posva

7 years, 9 months ago (2013-02-27 22:36:28 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r19178 (presubmit successful).