- Do not use the ? operator in the List factory.

runtime/lib/array.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "platform/assert.h"
 #include "vm/bootstrap_natives.h"
 #include "vm/assembler.h"
 #include "vm/bigint_operations.h"
 #include "vm/exceptions.h"
 #include "vm/native_entry.h"
 #include "vm/object.h"
 
 namespace dart {
 
 DEFINE_NATIVE_ENTRY(ObjectArray_allocate, 2) {
   const AbstractTypeArguments& type_arguments =
-      AbstractTypeArguments::CheckedHandle(arguments->NativeArgAt(0));
+      AbstractTypeArguments::CheckedHandle(isolate, arguments->NativeArgAt(0));
   ASSERT(type_arguments.IsNull() ||
          (type_arguments.IsInstantiated() && (type_arguments.Length() == 1)));
-  GET_NON_NULL_NATIVE_ARGUMENT(Smi, length, arguments->NativeArgAt(1));
-  intptr_t len = length.Value();
+  const Instance& length = Instance::CheckedHandle(
+      isolate, arguments->NativeArgAt(1));
+  if (!length.IsSmi()) {
+    const String& error = String::Handle(String::NewFormatted(
+        "Length must be an integer in the range [0..%"Pd"].",
+        Array::kMaxElements));
+    const Array& args = Array::Handle(Array::New(1));
+    args.SetAt(0, error);
+    Exceptions::ThrowByType(Exceptions::kArgument, args);
+  }
+  intptr_t len = Smi::Cast(length).Value();
   if (len < 0 || len > Array::kMaxElements) {
     const String& error = String::Handle(String::NewFormatted(
-        "length (%"Pd") must be in the range [0..%"Pd"]",
+        "Length (%"Pd") must be an integer in the range [0..%"Pd"].",
         len, Array::kMaxElements));
     const Array& args = Array::Handle(Array::New(1));
     args.SetAt(0, error);
     Exceptions::ThrowByType(Exceptions::kArgument, args);
   }
-  const Array& new_array = Array::Handle(Array::New(length.Value()));
+  const Array& new_array = Array::Handle(Array::New(len));
   new_array.SetTypeArguments(type_arguments);
   return new_array.raw();
 }
 
 
 DEFINE_NATIVE_ENTRY(ObjectArray_getIndexed, 2) {
   const Array& array = Array::CheckedHandle(arguments->NativeArgAt(0));
   GET_NON_NULL_NATIVE_ARGUMENT(Smi, index, arguments->NativeArgAt(1));
   if ((index.Value() < 0) || (index.Value() >= array.Length())) {
     const Array& args = Array::Handle(Array::New(1));
@@ skipping 60 matching lines @@
   } else {
     for (intptr_t i = 0; i < icount; i++) {
       src_obj = source.At(isrc_start + i);
       dest.SetAt(idst_start + i, src_obj);
     }
   }
   return Object::null();
 }
 
 }  // namespace dart