Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(591)

Issue 12335131: Make List.from default to not growable. (Closed)

Created:
7 years, 9 months ago by Lasse Reichstein Nielsen
Modified:
7 years, 9 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Make List.from default to not growable. Committed: https://code.google.com/p/dart/source/detail?r=19130

Patch Set 1 #

Patch Set 2 : Fix one more from. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -11 lines) Patch
M pkg/pathos/lib/path.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/scheduled_test/lib/src/schedule.dart View 1 chunk +1 line, -2 lines 0 comments Download
M samples/third_party/dromaeo/Suites.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/compiler/implementation/lib/js_array.dart View 2 chunks +2 lines, -1 line 0 comments Download
M sdk/lib/_internal/compiler/implementation/mirrors/dart2js_mirror.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/ssa/bailout.dart View 1 chunk +2 lines, -1 line 0 comments Download
M sdk/lib/core/list.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/co19/co19-dart2dart.status View 1 chunk +24 lines, -0 lines 0 comments Download
M tests/co19/co19-dart2js.status View 1 chunk +24 lines, -0 lines 0 comments Download
M tests/co19/co19-runtime.status View 1 chunk +24 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Lasse Reichstein Nielsen
7 years, 9 months ago (2013-02-27 13:02:28 UTC) #1
floitsch
LGTM.
7 years, 9 months ago (2013-02-27 13:04:47 UTC) #2
Lasse Reichstein Nielsen
7 years, 9 months ago (2013-02-27 13:09:23 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r19130 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698