sdk/lib/core/list.dart - Issue 12335131: Make List.from default to not growable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/core/list.dart

Issue 12335131: Make List.from default to not growable. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Fix one more from. Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sdk/lib/core/list.dart

diff --git a/sdk/lib/core/list.dart b/sdk/lib/core/list.dart

index cdd002f5ea43e4fab34045da0d7015e07513871b..846d304194230b2a5c5afddc6b3c66afd8075cbe 100644

--- a/sdk/lib/core/list.dart

+++ b/sdk/lib/core/list.dart

@@ -60,7 +60,7 @@ abstract class List<E> implements Collection<E> {

* The length of the returned list is not fixed.

- factory List.from(Iterable other, { bool growable: true }) {

+ factory List.from(Iterable other, { bool growable: false }) {

List<E> list = new List<E>();

for (E e in other) {

list.add(e);