Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1233263003: dart2js: add isConstantsHolder to Holder class. (Closed)

Created:
5 years, 5 months ago by floitsch
Modified:
5 years, 5 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 4

Patch Set 2 : Address comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -13 lines) Patch
M pkg/compiler/lib/src/js_emitter/model.dart View 1 chunk +3 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart View 1 4 chunks +18 lines, -10 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/program_builder/registry.dart View 1 chunk +9 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
floitsch
5 years, 5 months ago (2015-07-17 15:58:31 UTC) #2
Siggi Cherem (dart-lang)
lgtm https://codereview.chromium.org/1233263003/diff/1/pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart File pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart (right): https://codereview.chromium.org/1233263003/diff/1/pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart#newcode261 pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart:261: // building a static field. (Note that the ...
5 years, 5 months ago (2015-07-17 16:04:04 UTC) #3
floitsch
https://codereview.chromium.org/1233263003/diff/1/pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart File pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart (right): https://codereview.chromium.org/1233263003/diff/1/pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart#newcode261 pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart:261: // building a static field. (Note that the $ ...
5 years, 5 months ago (2015-07-17 17:27:18 UTC) #4
floitsch
5 years, 5 months ago (2015-07-17 17:27:35 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
784e2441110af2c74f79a8b30b0935251fc31a16 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698