Issue 12330174: Revert "Revert "Converting dart:html to use DateTime rather than Date.""

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12330174: Revert "Revert "Converting dart:html to use DateTime rather than Date."" (Closed)

Created:
7 years, 9 months ago by blois

Modified:
7 years, 9 months ago

Reviewers:
sra1

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Revert "Revert "Converting dart:html to use DateTime rather than Date."" Re-submitting change to use DateTime rather than Date. I'm just disabling the new tests I added since they're failing on Dartium. Opened a bug tracking the Dartium and tests changes. This means that dates are broken on Dartium, but they were broken everywhere before this change. BUG= Committed: https://code.google.com/p/dart/source/detail?r=19325

Patch Set 1 #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+110 lines, -78 lines)			Patch
M	sdk/lib/html/dart2js/html_dart2js.dart	View	25 chunks	+64 lines, -51 lines	0 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View	7 chunks	+7 lines, -18 lines	0 comments	Download
M	sdk/lib/indexed_db/dart2js/indexed_db_dart2js.dart	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	tests/html/fileapi_test.dart	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	tests/html/input_element_test.dart	View	1 chunk	+10 lines, -0 lines	0 comments	Download
M	tools/dom/scripts/generator.py	View	2 chunks	+5 lines, -1 line	0 comments	Download
M	tools/dom/scripts/systemhtml.py	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	tools/dom/src/dart2js_Conversions.dart	View	1 chunk	+9 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

blois

7 years, 9 months ago (2013-03-01 17:34:48 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r19325 (presubmit successful).

Expand Messages | Collapse Messages