Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1602)

Unified Diff: tools/dom/scripts/systemhtml.py

Issue 12330174: Revert "Revert "Converting dart:html to use DateTime rather than Date."" (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/dom/scripts/generator.py ('k') | tools/dom/src/dart2js_Conversions.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/dom/scripts/systemhtml.py
diff --git a/tools/dom/scripts/systemhtml.py b/tools/dom/scripts/systemhtml.py
index dd9d1f5c936a7e2f5fffd2681e2096742b7e4ef2..7a0c5dd35d437668aeb3070f1f481d129fa00cfa 100644
--- a/tools/dom/scripts/systemhtml.py
+++ b/tools/dom/scripts/systemhtml.py
@@ -820,9 +820,9 @@ class Dart2JSBackend(HtmlDartGenerator):
def _AddConvertingGetter(self, attr, html_name, conversion):
self._members_emitter.Emit(
- '\n $RETURN_TYPE get $HTML_NAME => $CONVERT(this._$(HTML_NAME));'
+ '\n $RETURN_TYPE get $HTML_NAME => $CONVERT(this._get_$(HTML_NAME));'
"\n @JSName('$NAME')"
- '\n $(ANNOTATIONS)final $NATIVE_TYPE _$HTML_NAME;'
+ '\n $(ANNOTATIONS)final $NATIVE_TYPE _get_$HTML_NAME;'
'\n',
ANNOTATIONS=self._Annotations(attr.type.id, html_name),
CONVERT=conversion.function_name,
@@ -835,9 +835,9 @@ class Dart2JSBackend(HtmlDartGenerator):
self._members_emitter.Emit(
# TODO(sra): Use metadata to provide native name.
'\n void set $HTML_NAME($INPUT_TYPE value) {'
- '\n this._$HTML_NAME = $CONVERT(value);'
+ '\n this._set_$HTML_NAME = $CONVERT(value);'
'\n }'
- '\n void set _$HTML_NAME(/*$NATIVE_TYPE*/ value) {'
+ '\n void set _set_$HTML_NAME(/*$NATIVE_TYPE*/ value) {'
'\n JS("void", "#.$NAME = #", this, value);'
'\n }'
'\n',
« no previous file with comments | « tools/dom/scripts/generator.py ('k') | tools/dom/src/dart2js_Conversions.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698