Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 12330109: dart:io | Fix writing to a Socket while and after calling destroy() on it. (Closed)

Created:
7 years, 10 months ago by Bill Hesse
Modified:
7 years, 10 months ago
Reviewers:
Anders Johnsen
CC:
reviews_dartlang.org
Visibility:
Public.

Description

dart:io | Fix writing to a Socket while and after calling destroy() on it. BUG=dartbug.com/8681 TEST=standalone/io/http_client_request_test Committed: https://code.google.com/p/dart/source/detail?r=18969

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -12 lines) Patch
M runtime/bin/socket_patch.dart View 2 chunks +13 lines, -11 lines 2 comments Download
M tests/standalone/standalone.status View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Bill Hesse
7 years, 10 months ago (2013-02-25 14:31:02 UTC) #1
Anders Johnsen
LGTM https://codereview.chromium.org/12330109/diff/1/runtime/bin/socket_patch.dart File runtime/bin/socket_patch.dart (right): https://codereview.chromium.org/12330109/diff/1/runtime/bin/socket_patch.dart#newcode661 runtime/bin/socket_patch.dart:661: if (socket._raw != null) { == null) return ...
7 years, 10 months ago (2013-02-25 14:36:37 UTC) #2
Bill Hesse
https://codereview.chromium.org/12330109/diff/1/runtime/bin/socket_patch.dart File runtime/bin/socket_patch.dart (right): https://codereview.chromium.org/12330109/diff/1/runtime/bin/socket_patch.dart#newcode661 runtime/bin/socket_patch.dart:661: if (socket._raw != null) { On 2013/02/25 14:36:37, Anders ...
7 years, 10 months ago (2013-02-25 14:49:23 UTC) #3
Bill Hesse
7 years, 10 months ago (2013-02-25 14:52:47 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r18969 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698