dart:io | Fix writing to a Socket while and after calling destroy() on it.

runtime/bin/socket_patch.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 patch class RawServerSocket  {
   /* patch */ static Future<RawServerSocket> bind([String address = "127.0.0.1",
                                                    int port = 0,
                                                    int backlog = 0]) {
     return _RawServerSocket.bind(address, port, backlog);
   }
@@ skipping 640 matching lines @@
 class _SocketStreamConsumer extends StreamConsumer<List<int>, Socket> {
   StreamSubscription subscription;
   final _Socket socket;
   int offset;
   List<int> buffer;
   bool paused = false;
 
   _SocketStreamConsumer(this.socket);
 
   Future<Socket> consume(Stream<List<int>> stream) {
-    subscription = stream.listen(
-        (data) {
-          assert(!paused);
-          assert(buffer == null);
-          buffer = data;
-          offset = 0;
-          write();
-        },
-        onDone: () {
-          socket._consumerDone();
-        });
+    if (socket._raw != null) {

[Anders Johnsen, 2013/02/25 14:36:37]

== null) return socket._doneFuture;, to avoid nesting?

[Bill Hesse, 2013/02/25 14:49:23]

I just put that nesting in, on purpose, because it is so much better this way.

+      subscription = stream.listen((data) {
+        assert(!paused);
+        assert(buffer == null);
+        buffer = data;
+        offset = 0;
+        write();
+      },
+      onDone: () {
+        socket._consumerDone();
+      });
+    }
     return socket._doneFuture;
   }
 
   void write() {
     try {
       if (subscription == null) return;
       assert(buffer != null);
       // Write as much as possible.
       offset += socket._write(buffer, offset, buffer.length - offset);
       if (offset < buffer.length) {
         if (!paused) {
           paused = true;
           // TODO(ajohnsen): It would be nice to avoid this check.
           // Some info: socket._write can emit an event, if it fails to write.
           // If the user closes the socket in that event, stop() will be called
           // before we get a change to pause.
           if (subscription == null) return;
           subscription.pause();
         }
         socket._enableWriteEvent();
       } else {
         buffer = null;
         if (paused) {
           paused = false;
           subscription.resume();
         }
       }
     } catch (e) {
+      stop();
       socket._consumerDone(e);
     }
   }
 
   void stop() {
     if (subscription == null) return;
     subscription.cancel();
     subscription = null;
     socket._disableWriteEvent();
   }
@@ skipping 204 matching lines @@
     _raw.onBadCertificate = callback;
   }
 
   X509Certificate get peerCertificate {
     if (_raw == null) {
      throw new StateError("peerCertificate called on destroyed SecureSocket");
     }
     return _raw.peerCertificate;
   }
 }