Issue 12328055: Insert missing test for unboxed mint support when inlining _setIndexed, getUint32, getInt32.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12328055: Insert missing test for unboxed mint support when inlining _setIndexed, getUint32, getInt32. (Closed)

Created:
7 years, 10 months ago by Florian Schneider

Modified:
7 years, 10 months ago

Reviewers:
Vyacheslav Egorov (Google)

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Insert missing test for unboxed mint support when inlining _setIndexed, getInt32, getUint32. Int32Array and Uint32Array can only be optimized on ia32 when SSE 4.1 is supported. Committed: https://code.google.com/p/dart/source/detail?r=18890

Patch Set 1 #

Patch Set 2 : #

Total comments: 3

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -0 lines)			Patch
	M	runtime/vm/flow_graph_optimizer.cc	View	1	2 chunks	+15 lines, -0 lines	3 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Vyacheslav Egorov (Google)

lgtm https://codereview.chromium.org/12328055/diff/3001/runtime/vm/flow_graph_optimizer.cc File runtime/vm/flow_graph_optimizer.cc (right): https://codereview.chromium.org/12328055/diff/3001/runtime/vm/flow_graph_optimizer.cc#newcode691 runtime/vm/flow_graph_optimizer.cc:691: // Check if elements fit into a smi ...

7 years, 10 months ago (2013-02-22 13:20:43 UTC) #2

Florian Schneider

7 years, 10 months ago (2013-02-22 13:41:28 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r18890 (presubmit successful).

Expand Messages | Collapse Messages