Insert missing test for unboxed mint support when inlining _setIndexed, getUint32, getInt32.

runtime/vm/flow_graph_optimizer.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/flow_graph_optimizer.h"
 
 #include "vm/bit_vector.h"
 #include "vm/cha.h"
 #include "vm/flow_graph_builder.h"
 #include "vm/flow_graph_compiler.h"
@@ skipping 670 matching lines @@
       // Check that value is always smi.
       value_check = ICData::New(Function::Handle(),
                                 String::Handle(),
                                 Isolate::kNoDeoptId,
                                 1);
       value_check.AddReceiverCheck(kSmiCid, Function::Handle());
       break;
     }
     case kInt32ArrayCid:
     case kUint32ArrayCid:
+      // Check if elements fit into a smi or the platform supports unboxed

[Vyacheslav Egorov (Google), 2013/02/22 13:20:43]

Consider moving this to the function start and using 
FlowGraphCompiler::ElementSizeFor in a check.

+      // mints.
+      if ((kSmiBits < 32) && !FlowGraphCompiler::SupportsUnboxedMints()) {
+        return false;
+      }
       // We don't have ICData for the value stored, so we optimistically assume
       // smis first. If we ever deoptimized here, we require to unbox the value
       // before storing to handle the mint case, too.
       if (call->ic_data()->deopt_reason() == kDeoptUnknown) {
         value_check = ICData::New(Function::Handle(),
                                   String::Handle(),
                                   Isolate::kNoDeoptId,
                                   1);
         value_check.AddReceiverCheck(kSmiCid, Function::Handle());
       }
@@ skipping 818 matching lines @@
       case MethodRecognizer::kByteArrayBaseGetUint8:
         array_op = BuildByteArrayViewLoad(call, class_ids[0], kUint8ArrayCid);
         break;
       case MethodRecognizer::kByteArrayBaseGetInt16:
         array_op = BuildByteArrayViewLoad(call, class_ids[0], kInt16ArrayCid);
         break;
       case MethodRecognizer::kByteArrayBaseGetUint16:
         array_op = BuildByteArrayViewLoad(call, class_ids[0], kUint16ArrayCid);
         break;
       case MethodRecognizer::kByteArrayBaseGetInt32:
+        // Check if elements fit into a smi or the platform supports unboxed

[Vyacheslav Egorov (Google), 2013/02/22 13:20:43]

Consider moving this to the function start and using 
FlowGraphCompiler::ElementSizeFor in a check.

+        // mints.
+        if ((kSmiBits < 32) && !FlowGraphCompiler::SupportsUnboxedMints()) {
+          return false;
+        }
         array_op = BuildByteArrayViewLoad(call, class_ids[0], kInt32ArrayCid);
         break;
       case MethodRecognizer::kByteArrayBaseGetUint32:
+        // Check if elements fit into a smi or the platform supports unboxed

[Vyacheslav Egorov (Google), 2013/02/22 13:20:43]

Consider moving this to the function start and using 
FlowGraphCompiler::ElementSizeFor in a check.

+        // mints.
+        if ((kSmiBits < 32) && !FlowGraphCompiler::SupportsUnboxedMints()) {
+          return false;
+        }
         array_op = BuildByteArrayViewLoad(call, class_ids[0], kUint32ArrayCid);
         break;
       case MethodRecognizer::kByteArrayBaseGetFloat32:
         array_op = BuildByteArrayViewLoad(call, class_ids[0], kFloat32ArrayCid);
         break;
       case MethodRecognizer::kByteArrayBaseGetFloat64:
         array_op = BuildByteArrayViewLoad(call, class_ids[0], kFloat64ArrayCid);
         break;
       default:
         // Unsupported method.
@@ skipping 2715 matching lines @@
 
   if (FLAG_trace_constant_propagation) {
     OS::Print("\n==== After constant propagation ====\n");
     FlowGraphPrinter printer(*graph_);
     printer.PrintBlocks();
   }
 }
 
 
 }  // namespace dart