Make sure package names are URL encoded.

Make sure package names are URL encoded.

If you happen to have a weird package name like "/* blah *?" you
would get a nasty HTTP error when it tried to jam that in a URL.
Instead, this will give you a friendlier 'package "/* blah */" not found error."
BUG=http://code.google.com/p/dart/issues/detail?id=7466

Committed: https://code.google.com/p/dart/source/detail?r=18849

[nweiz, 2013-02-21 01:21:58]

lgtm

https://codereview.chromium.org/12328021/diff/1/utils/pub/hosted_source.dart
File utils/pub/hosted_source.dart (right):

https://codereview.chromium.org/12328021/diff/1/utils/pub/hosted_source.dart#...
utils/pub/hosted_source.dart:166: return new Uri(pattern(server, package,
id.version.toString()));
We should probably URL-encode the version as well; it's possible for "+" to be
misinterpreted somewhere along the line.

[Bob Nystrom, 2013-02-21 18:59:54]

Committed patchset #2 manually as r18849 (presubmit successful).

[Bob Nystrom, 2013-02-21 19:00:03]

https://codereview.chromium.org/12328021/diff/1/utils/pub/hosted_source.dart
File utils/pub/hosted_source.dart (right):

https://codereview.chromium.org/12328021/diff/1/utils/pub/hosted_source.dart#...
utils/pub/hosted_source.dart:166: return new Uri(pattern(server, package,
id.version.toString()));
On 2013/02/21 01:21:58, nweiz wrote:
> We should probably URL-encode the version as well; it's possible for "+" to be
> misinterpreted somewhere along the line.

Good catch. Forgot about "+" in versions. Done.