Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Side by Side Diff: utils/tests/pub/install/hosted/install_test.dart

Issue 12328021: Make sure package names are URL encoded. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: URL encode version too. Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « utils/pub/validator/name.dart ('k') | utils/tests/pub/validator_test.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library pub_tests; 5 library pub_tests;
6 6
7 import 'dart:io'; 7 import 'dart:io';
8 8
9 import '../../test_pub.dart'; 9 import '../../test_pub.dart';
10 10
11 main() { 11 main() {
12 initConfig();
12 integration('installs a package from a pub server', () { 13 integration('installs a package from a pub server', () {
13 servePackages([package("foo", "1.2.3")]); 14 servePackages([package("foo", "1.2.3")]);
14 15
15 appDir([dependency("foo", "1.2.3")]).scheduleCreate(); 16 appDir([dependency("foo", "1.2.3")]).scheduleCreate();
16 17
17 schedulePub(args: ['install'], 18 schedulePub(args: ['install'],
18 output: new RegExp("Dependencies installed!\$")); 19 output: new RegExp("Dependencies installed!\$"));
19 20
20 cacheDir({"foo": "1.2.3"}).scheduleValidate(); 21 cacheDir({"foo": "1.2.3"}).scheduleValidate();
21 packagesDir({"foo": "1.2.3"}).scheduleValidate(); 22 packagesDir({"foo": "1.2.3"}).scheduleValidate();
22 }); 23 });
24
25 integration('URL encodes the package name', () {
26 servePackages([]);
27
28 appDir([dependency("bad name!", "1.2.3")]).scheduleCreate();
29
30 schedulePub(args: ['install'],
31 error: new RegExp('Could not find package "bad name!" at '
32 'http://localhost:'),
33 exitCode: 1);
34 });
23 } 35 }
OLDNEW
« no previous file with comments | « utils/pub/validator/name.dart ('k') | utils/tests/pub/validator_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698