Issue 12328019: - Improve the message for NoSuchMethodErrors that are

Issue 12328019: - Improve the message for NoSuchMethodErrors that are (Closed)

Created:
7 years, 10 months ago by Ivan Posva

Modified:
7 years, 10 months ago

Reviewers:
regis, kasperl

CC:
reviews_dartlang.org, kasperl

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

- Improve the message for NoSuchMethodErrors that are determined statically at compile time. Committed: https://code.google.com/p/dart/source/detail?r=18848

Patch Set 2 : #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+253 lines, -43 lines)			Patch
M	runtime/lib/errors_patch.dart	View	1	3 chunks	+60 lines, -3 lines	0 comments	Download
A	runtime/lib/invocation_mirror.h	View		1 chunk	+48 lines, -0 lines	0 comments	Download
M	runtime/lib/invocation_mirror_patch.dart	View	1	1 chunk	+18 lines, -3 lines	0 comments	Download
M	runtime/lib/lib_sources.gypi	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/lib/object.cc	View	1	2 chunks	+9 lines, -7 lines	0 comments	Download
M	runtime/lib/object_patch.dart	View	1	2 chunks	+2 lines, -0 lines	0 comments	Download
M	runtime/vm/bootstrap_natives.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/dart_entry.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/dart_entry.cc	View	1	2 chunks	+5 lines, -4 lines	0 comments	Download
M	runtime/vm/debugger_api_impl_test.cc	View	1	1 chunk	+5 lines, -3 lines	0 comments	Download
M	runtime/vm/exceptions.cc	View	1	3 chunks	+6 lines, -1 line	0 comments	Download
M	runtime/vm/flow_graph_builder.h	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	runtime/vm/flow_graph_builder.cc	View	1	5 chunks	+25 lines, -7 lines	0 comments	Download
M	runtime/vm/object.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/object.cc	View	1	1 chunk	+10 lines, -0 lines	0 comments	Download
M	runtime/vm/parser.h	View	1	2 chunks	+4 lines, -1 line	0 comments	Download
M	runtime/vm/parser.cc	View	1	13 chunks	+54 lines, -11 lines	0 comments	Download
M	runtime/vm/stack_frame_arm.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

regis

LGTM https://codereview.chromium.org/12328019/diff/1/runtime/lib/errors_patch.dart File runtime/lib/errors_patch.dart (right): https://codereview.chromium.org/12328019/diff/1/runtime/lib/errors_patch.dart#newcode51 runtime/lib/errors_patch.dart:51: this._invocation_type = 0; What is 0? https://codereview.chromium.org/12328019/diff/1/runtime/lib/errors_patch.dart#newcode54 runtime/lib/errors_patch.dart:54: ...

7 years, 10 months ago (2013-02-21 00:48:18 UTC) #2

Ivan Posva

https://codereview.chromium.org/12328019/diff/1/runtime/lib/errors_patch.dart File runtime/lib/errors_patch.dart (right): https://codereview.chromium.org/12328019/diff/1/runtime/lib/errors_patch.dart#newcode51 runtime/lib/errors_patch.dart:51: this._invocation_type = 0; On 2013/02/21 00:48:18, regis wrote: > ...

7 years, 10 months ago (2013-02-21 18:51:39 UTC) #3

Ivan Posva

Committed patchset #2 manually as r18848 (presubmit successful).

7 years, 10 months ago (2013-02-21 18:53:39 UTC) #4

Message was sent while issue was closed.

Is it possible to test this?

Expand Messages | Collapse Messages