Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(900)

Unified Diff: runtime/vm/dart_entry.cc

Issue 12328019: - Improve the message for NoSuchMethodErrors that are (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/dart_entry.h ('k') | runtime/vm/debugger_api_impl_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/dart_entry.cc
===================================================================
--- runtime/vm/dart_entry.cc (revision 18846)
+++ runtime/vm/dart_entry.cc (working copy)
@@ -326,6 +326,7 @@
RawObject* DartLibraryCalls::ExceptionCreate(const Library& lib,
const String& class_name,
+ const String& constructor_name,
const Array& arguments) {
const Class& cls = Class::Handle(lib.LookupClassAllowPrivate(class_name));
ASSERT(!cls.IsNull());
@@ -343,10 +344,10 @@
constructor_arguments.SetAt((i + kNumExtraArgs), obj);
}
- String& constructor_name = String::Handle(
- String::Concat(class_name, Symbols::Dot()));
- Function& constructor =
- Function::Handle(cls.LookupConstructor(constructor_name));
+ const String& function_name = String::Handle(
+ String::Concat(class_name, constructor_name));
+ const Function& constructor =
+ Function::Handle(cls.LookupConstructorAllowPrivate(function_name));
ASSERT(!constructor.IsNull());
const Object& retval =
Object::Handle(DartEntry::InvokeStatic(constructor, constructor_arguments));
« no previous file with comments | « runtime/vm/dart_entry.h ('k') | runtime/vm/debugger_api_impl_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698