Issue 123263003: Make the Platform.environment return value an unmodifiable map

Issue 123263003: Make the Platform.environment return value an unmodifiable map (Closed)

Created:
6 years, 11 months ago by Søren Gjesse

Modified:
6 years, 11 months ago

Reviewers:
Anders Johnsen, kustemann

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Make the Platform.environment return value an unmodifiable map R=ajohnsen@google.com, kustemann@google.com BUG=http://dartbug.com/15872 Committed: https://code.google.com/p/dart/source/detail?r=31468

Patch Set 2 : Addressed review comments #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+39 lines, -22 lines)			Patch
M	runtime/bin/process_patch.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/io/platform.dart	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	sdk/lib/io/platform_impl.dart	View	1	2 chunks	+33 lines, -20 lines	0 comments	Download
M	tests/standalone/io/process_environment_test.dart	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	tools/testing/dart/test_runner.dart	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Anders Johnsen

lgtm https://codereview.chromium.org/123263003/diff/1/runtime/bin/process_patch.dart File runtime/bin/process_patch.dart (right): https://codereview.chromium.org/123263003/diff/1/runtime/bin/process_patch.dart#newcode201 runtime/bin/process_patch.dart:201: environment = new Map.from(Platform.environment)..addAll(environment); Hmm, this may be ...

6 years, 11 months ago (2014-01-05 20:41:21 UTC) #2

Søren Gjesse

https://codereview.chromium.org/123263003/diff/1/runtime/bin/process_patch.dart File runtime/bin/process_patch.dart (right): https://codereview.chromium.org/123263003/diff/1/runtime/bin/process_patch.dart#newcode201 runtime/bin/process_patch.dart:201: environment = new Map.from(Platform.environment)..addAll(environment); On 2014/01/05 20:41:21, Anders Johnsen ...

6 years, 11 months ago (2014-01-06 10:17:32 UTC) #3

Søren Gjesse

6 years, 11 months ago (2014-01-06 10:18:31 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r31468 (presubmit successful).

Expand Messages | Collapse Messages