Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Side by Side Diff: tools/testing/dart/test_runner.dart

Issue 123263003: Make the Platform.environment return value an unmodifiable map (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Addressed review comments Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « tests/standalone/io/process_environment_test.dart ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 /** 5 /**
6 * Classes and methods for executing tests. 6 * Classes and methods for executing tests.
7 * 7 *
8 * This module includes: 8 * This module includes:
9 * - Managing parallel execution of tests, including timeout checks. 9 * - Managing parallel execution of tests, including timeout checks.
10 * - Evaluating the output of each test as pass/fail/crash/timeout. 10 * - Evaluating the output of each test as pass/fail/crash/timeout.
(...skipping 1434 matching lines...) Expand 10 before | Expand all | Expand 10 after
1445 new DateTime.now().difference(startTime), 1445 new DateTime.now().difference(startTime),
1446 compilationSkipped); 1446 compilationSkipped);
1447 return commandOutput; 1447 return commandOutput;
1448 } 1448 }
1449 1449
1450 Future _drainStream(Stream<List<int>> source, List<int> destination) { 1450 Future _drainStream(Stream<List<int>> source, List<int> destination) {
1451 return source.listen(destination.addAll).asFuture(); 1451 return source.listen(destination.addAll).asFuture();
1452 } 1452 }
1453 1453
1454 Map<String, String> _createProcessEnvironment() { 1454 Map<String, String> _createProcessEnvironment() {
1455 var environment = io.Platform.environment; 1455 var environment = new Map.from(io.Platform.environment);
1456 1456
1457 if (command.environmentOverrides != null) { 1457 if (command.environmentOverrides != null) {
1458 for (var key in command.environmentOverrides.keys) { 1458 for (var key in command.environmentOverrides.keys) {
1459 environment[key] = command.environmentOverrides[key]; 1459 environment[key] = command.environmentOverrides[key];
1460 } 1460 }
1461 } 1461 }
1462 for (var excludedEnvironmentVariable in EXCLUDED_ENVIRONMENT_VARIABLES) { 1462 for (var excludedEnvironmentVariable in EXCLUDED_ENVIRONMENT_VARIABLES) {
1463 environment.remove(excludedEnvironmentVariable); 1463 environment.remove(excludedEnvironmentVariable);
1464 } 1464 }
1465 1465
(...skipping 1003 matching lines...) Expand 10 before | Expand all | Expand 10 after
2469 } 2469 }
2470 } 2470 }
2471 2471
2472 void eventAllTestsDone() { 2472 void eventAllTestsDone() {
2473 for (var listener in _eventListener) { 2473 for (var listener in _eventListener) {
2474 listener.allDone(); 2474 listener.allDone();
2475 } 2475 }
2476 _allDone(); 2476 _allDone();
2477 } 2477 }
2478 } 2478 }
OLDNEW
« no previous file with comments | « tests/standalone/io/process_environment_test.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698