Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Issue 1232423004: dart2js: check for the full getter/setter prefixes (fix #23828) (Closed)

Created:
5 years, 5 months ago by Siggi Cherem (dart-lang)
Modified:
5 years, 5 months ago
Reviewers:
floitsch, herhut
CC:
reviews_dartlang.org, Harry Terkelsen
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart2js: check for the full getter/setter prefixes (fix #23828) R=floitsch@google.com Committed: https://github.com/dart-lang/sdk/commit/baf00c19199e6739bed804e1f9c022f476c5d75a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -12 lines) Patch
M pkg/compiler/lib/src/js_emitter/full_emitter/nsm_emitter.dart View 1 chunk +2 lines, -2 lines 0 comments Download
A + tests/compiler/dart2js_extra/23828_test.dart View 1 chunk +7 lines, -10 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Siggi Cherem (dart-lang)
5 years, 5 months ago (2015-07-13 20:59:55 UTC) #2
floitsch
LGTM.
5 years, 5 months ago (2015-07-14 09:49:39 UTC) #3
Siggi Cherem (dart-lang)
5 years, 5 months ago (2015-07-14 14:43:10 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
baf00c19199e6739bed804e1f9c022f476c5d75a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698