Provide stdout and stderr output in the Observatory debugger.

Provide stdout and stderr output in the Observatory debugger.

Implement two new streams, 'Stdout' and 'Stderr' in the service protocol.

BUG=
R=johnmccutchan@google.com

Committed: https://github.com/dart-lang/sdk/commit/e4684c7627e44c1d2c22a6ed039b220079c8ba4a

[turnidge, 2015-07-10 22:11:31]

turnidge@google.com changed reviewers:
+ johnmccutchan@google.com

[Cutch, 2015-07-13 14:10:29]

https://codereview.chromium.org/1232193003/diff/20001/runtime/bin/builtin_nat...
File runtime/bin/builtin_natives.cc (right):

https://codereview.chromium.org/1232193003/diff/20001/runtime/bin/builtin_nat...
runtime/bin/builtin_natives.cc:123: extern bool captureStdout;
capture_stdout

https://codereview.chromium.org/1232193003/diff/20001/runtime/bin/builtin_nat...
runtime/bin/builtin_natives.cc:136: fwrite(chars, 1, length, stdout);
s/1/sizeof(*chars)

https://codereview.chromium.org/1232193003/diff/20001/runtime/bin/file.cc
File runtime/bin/file.cc (right):

https://codereview.chromium.org/1232193003/diff/20001/runtime/bin/file.cc#new...
runtime/bin/file.cc:21: bool captureStdio = false;
capture_stdio

https://codereview.chromium.org/1232193003/diff/20001/runtime/bin/file.cc#new...
runtime/bin/file.cc:24: bool captureStdout = false;
capture_stdout

...

https://codereview.chromium.org/1232193003/diff/20001/runtime/bin/file.cc#new...
runtime/bin/file.cc:67: if (fd == 1 && captureStdout) {
(fd == STDOUT_FILENO) &&

https://codereview.chromium.org/1232193003/diff/20001/runtime/bin/file.cc#new...
runtime/bin/file.cc:71: } else if (fd == 2 && captureStderr) {
(fd == STDERR_FILENO) &&

https://codereview.chromium.org/1232193003/diff/20001/runtime/vm/dart_api_imp...
File runtime/vm/dart_api_impl.cc (right):

https://codereview.chromium.org/1232193003/diff/20001/runtime/vm/dart_api_imp...
runtime/vm/dart_api_impl.cc:5714: return Api::NewError(
Do we need to be this careful? Can't we just always call
Service::SetEmbedderStreamCallbacks ?

https://codereview.chromium.org/1232193003/diff/20001/runtime/vm/service.cc
File runtime/vm/service.cc (right):

https://codereview.chromium.org/1232193003/diff/20001/runtime/vm/service.cc#n...
runtime/vm/service.cc:84: const char* const Service::kGraphStreamId = "_Graph";
Would be nice if we had an array of streams (with the name and the "needs
events" flag being in a  structure together. Then, ListenStream and CancelStream
could be refactored to just loop over data.

[Cutch, 2015-07-13 16:24:54]

https://codereview.chromium.org/1232193003/diff/20001/runtime/observatory/tes...
File runtime/observatory/tests/service/capture_stdio_test.dart (right):

https://codereview.chromium.org/1232193003/diff/20001/runtime/observatory/tes...
runtime/observatory/tests/service/capture_stdio_test.dart:9: import
'dart:async';
sort imports

[turnidge, 2015-07-13 22:50:36]

PTAL

https://codereview.chromium.org/1232193003/diff/20001/runtime/bin/builtin_nat...
File runtime/bin/builtin_natives.cc (right):

https://codereview.chromium.org/1232193003/diff/20001/runtime/bin/builtin_nat...
runtime/bin/builtin_natives.cc:123: extern bool captureStdout;
On 2015/07/13 14:10:29, Cutch wrote:
> capture_stdout

Done.

https://codereview.chromium.org/1232193003/diff/20001/runtime/bin/builtin_nat...
runtime/bin/builtin_natives.cc:136: fwrite(chars, 1, length, stdout);
On 2015/07/13 14:10:29, Cutch wrote:
> s/1/sizeof(*chars)

Did this instead:

    uint8_t newline[] = { '\n' };
...
    Dart_ServiceSendDataEvent("Stdout", "WriteEvent",
                              newline, sizeof(newline));

https://codereview.chromium.org/1232193003/diff/20001/runtime/bin/file.cc
File runtime/bin/file.cc (right):

https://codereview.chromium.org/1232193003/diff/20001/runtime/bin/file.cc#new...
runtime/bin/file.cc:21: bool captureStdio = false;
On 2015/07/13 14:10:29, Cutch wrote:
> capture_stdio

Done.

https://codereview.chromium.org/1232193003/diff/20001/runtime/bin/file.cc#new...
runtime/bin/file.cc:24: bool captureStdout = false;
On 2015/07/13 14:10:29, Cutch wrote:
> capture_stdout
> 
> ...

Done.

https://codereview.chromium.org/1232193003/diff/20001/runtime/bin/file.cc#new...
runtime/bin/file.cc:67: if (fd == 1 && captureStdout) {
On 2015/07/13 14:10:29, Cutch wrote:
> (fd == STDOUT_FILENO) && 

Done.  Also fixed existing usage of 0, 1, 2 in File_OpenStdio and
File_GetStdioHandleType.

https://codereview.chromium.org/1232193003/diff/20001/runtime/bin/file.cc#new...
runtime/bin/file.cc:71: } else if (fd == 2 && captureStderr) {
On 2015/07/13 14:10:29, Cutch wrote:
> (fd == STDERR_FILENO) &&

Done.

https://codereview.chromium.org/1232193003/diff/20001/runtime/observatory/tes...
File runtime/observatory/tests/service/capture_stdio_test.dart (right):

https://codereview.chromium.org/1232193003/diff/20001/runtime/observatory/tes...
runtime/observatory/tests/service/capture_stdio_test.dart:9: import
'dart:async';
On 2015/07/13 16:24:54, Cutch wrote:
> sort imports

Done.

https://codereview.chromium.org/1232193003/diff/20001/runtime/vm/dart_api_imp...
File runtime/vm/dart_api_impl.cc (right):

https://codereview.chromium.org/1232193003/diff/20001/runtime/vm/dart_api_imp...
runtime/vm/dart_api_impl.cc:5714: return Api::NewError(
On 2015/07/13 14:10:29, Cutch wrote:
> Do we need to be this careful? Can't we just always call
> Service::SetEmbedderStreamCallbacks ?

I was going for consistency with the gc prologue and epilogue callbacks but I
agree that it does seem a little bit ornate.

https://codereview.chromium.org/1232193003/diff/20001/runtime/vm/service.cc
File runtime/vm/service.cc (right):

https://codereview.chromium.org/1232193003/diff/20001/runtime/vm/service.cc#n...
runtime/vm/service.cc:84: const char* const Service::kGraphStreamId = "_Graph";
On 2015/07/13 14:10:29, Cutch wrote:
> Would be nice if we had an array of streams (with the name and the "needs
> events" flag being in a  structure together. Then, ListenStream and
CancelStream
> could be refactored to just loop over data.

Done.

[Cutch, 2015-07-13 23:16:11]

lgtm

[turnidge, 2015-07-14 19:54:11]

Committed patchset #4 (id:60001) manually as
e4684c7627e44c1d2c22a6ed039b220079c8ba4a (presubmit successful).