runtime/vm/service_isolate.cc - Issue 1232193003: Provide stdout and stderr output in the Observatory debugger.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/service_isolate.cc

Issue 1232193003: Provide stdout and stderr output in the Observatory debugger. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: before commit Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/service_isolate.cc

diff --git a/runtime/vm/service_isolate.cc b/runtime/vm/service_isolate.cc

index 312667869ff20c14891cfb4979a79e37e5b6b83e..3779905093b7a5a401698fb608fec912ad4e4669 100644

--- a/runtime/vm/service_isolate.cc

+++ b/runtime/vm/service_isolate.cc

@@ -304,7 +304,8 @@ class ServiceIsolateNatives : public AllStatic {

Zone* zone = stack_zone.GetZone(); // Used by GET_NON_NULL_NATIVE_ARGUMENT.

HANDLESCOPE(isolate);

GET_NON_NULL_NATIVE_ARGUMENT(String, stream_id, arguments->NativeArgAt(0));

- Service::ListenStream(stream_id.ToCString());

+ bool result = Service::ListenStream(stream_id.ToCString());

+ arguments->SetReturn(Bool::Get(result));

}

static void CancelStream(Dart_NativeArguments args) {

« no previous file with comments | « runtime/vm/service_event.cc ('k') | no next file » | no next file with comments »