Issue 12316072: Some fixes in unittest after io v2

Issue 12316072: Some fixes in unittest after io v2 (Closed)

Created:
7 years, 10 months ago by Siggi Cherem (dart-lang)

Modified:
7 years, 10 months ago

Reviewers:
dgrove, gram

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Some fixes in unittest after io v2 Committed: https://code.google.com/p/dart/source/detail?r=18899

Patch Set 2 : also include htmlconfig #

Total comments: 2

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -28 lines)			Patch
M	pkg/unittest/lib/compact_vm_config.dart	View		3 chunks	+19 lines, -19 lines	2 comments	Download
M	pkg/unittest/lib/html_config.dart	View	1	3 chunks	+7 lines, -7 lines	0 comments	Download
M	pkg/unittest/lib/src/string_matchers.dart	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Siggi Cherem (dart-lang)

added fixes for stringbuffer in html_config too

7 years, 10 months ago (2013-02-22 17:32:58 UTC) #3

Siggi Cherem (dart-lang)

Committed patchset #2 manually as r18899 (presubmit successful).

7 years, 10 months ago (2013-02-22 17:34:25 UTC) #4

gram

lgtm https://codereview.chromium.org/12316072/diff/3001/pkg/unittest/lib/compact_vm_config.dart File pkg/unittest/lib/compact_vm_config.dart (right): https://codereview.chromium.org/12316072/diff/3001/pkg/unittest/lib/compact_vm_config.dart#newcode104 pkg/unittest/lib/compact_vm_config.dart:104: int nonVisible = _nonVisiblePrefix + color.length + Can ...

7 years, 10 months ago (2013-02-22 17:36:11 UTC) #5

Siggi Cherem (dart-lang)

7 years, 10 months ago (2013-02-22 17:38:59 UTC) #6

Message was sent while issue was closed.

https://codereview.chromium.org/12316072/diff/3001/pkg/unittest/lib/compact_v...
File pkg/unittest/lib/compact_vm_config.dart (right):

https://codereview.chromium.org/12316072/diff/3001/pkg/unittest/lib/compact_v...
pkg/unittest/lib/compact_vm_config.dart:104: int nonVisible = _nonVisiblePrefix
+ color.length  +
On 2013/02/22 17:36:11, gram wrote:
> Can you add a comment to this block of code please? It is not obvious what it
is
> doing.

already submitted this one, but will do in a separate CL.

Expand Messages | Collapse Messages