Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 12316036: Merge IO v2 branch to bleeding edge (Closed)

Created:
7 years, 10 months ago by Søren Gjesse
Modified:
7 years, 10 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 13

Patch Set 2 : Addressed revire comments from ager@ #

Patch Set 3 : Rebased to r18818 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9113 lines, -14004 lines) Patch
M pkg/http/lib/src/io_client.dart View 1 2 1 chunk +14 lines, -43 lines 0 comments Download
M pkg/http/lib/src/multipart_file.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M pkg/http/lib/src/multipart_request.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M pkg/http/test/client_test.dart View 1 2 1 chunk +40 lines, -37 lines 0 comments Download
M pkg/http/test/http_test.dart View 1 2 1 chunk +153 lines, -132 lines 0 comments Download
M pkg/http/test/request_test.dart View 1 2 2 chunks +55 lines, -52 lines 0 comments Download
M pkg/http/test/utils.dart View 1 2 3 chunks +71 lines, -73 lines 0 comments Download
M pkg/intl/tool/generate_locale_data_files.dart View 1 2 2 chunks +15 lines, -14 lines 0 comments Download
M pkg/webdriver/lib/webdriver.dart View 1 2 1 chunk +2 lines, -8 lines 0 comments Download
M runtime/bin/builtin_impl_sources.gypi View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/bin/directory.h View 1 2 3 chunks +4 lines, -6 lines 0 comments Download
M runtime/bin/directory.cc View 1 2 4 chunks +17 lines, -31 lines 0 comments Download
M runtime/bin/eventhandler_linux.cc View 1 2 2 chunks +9 lines, -3 lines 0 comments Download
M runtime/bin/eventhandler_macos.cc View 1 2 1 chunk +7 lines, -3 lines 0 comments Download
M runtime/bin/eventhandler_win.h View 1 2 9 chunks +22 lines, -11 lines 0 comments Download
M runtime/bin/eventhandler_win.cc View 1 2 16 chunks +133 lines, -85 lines 0 comments Download
M runtime/bin/file.h View 1 2 2 chunks +2 lines, -4 lines 0 comments Download
M runtime/bin/file.cc View 1 2 3 chunks +8 lines, -27 lines 0 comments Download
M runtime/bin/platform_win.cc View 1 2 1 chunk +1 line, -6 lines 0 comments Download
M runtime/bin/process.cc View 1 2 3 chunks +12 lines, -12 lines 0 comments Download
M runtime/bin/process_patch.dart View 1 2 8 chunks +87 lines, -131 lines 0 comments Download
M runtime/bin/secure_socket.cc View 1 2 1 chunk +22 lines, -11 lines 0 comments Download
M runtime/bin/secure_socket_patch.dart View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/bin/socket.cc View 1 2 13 chunks +27 lines, -14 lines 0 comments Download
M runtime/bin/socket_linux.cc View 1 2 2 chunks +3 lines, -7 lines 0 comments Download
M runtime/bin/socket_macos.cc View 1 2 2 chunks +3 lines, -7 lines 0 comments Download
M runtime/bin/socket_patch.dart View 1 2 2 chunks +753 lines, -438 lines 0 comments Download
M runtime/bin/socket_win.cc View 1 2 4 chunks +9 lines, -4 lines 0 comments Download
M runtime/bin/stdio_patch.dart View 1 2 1 chunk +10 lines, -16 lines 0 comments Download
M runtime/bin/utf_sources.gypi View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M runtime/lib/utf/utf_vm.dart View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/vm/dart_api_impl.cc View 1 2 3 chunks +83 lines, -4 lines 0 comments Download
M samples/buildhook1/build.dart View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M samples/buildhook2/build.dart View 1 2 3 chunks +11 lines, -8 lines 0 comments Download
M samples/chat/chat_server_lib.dart View 1 2 15 chunks +145 lines, -160 lines 0 comments Download
M samples/chat/chat_stress_client.dart View 1 2 4 chunks +45 lines, -55 lines 0 comments Download
M samples/tests/samples/chat/chat_server_test.dart View 1 2 6 chunks +49 lines, -69 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/dart2js.dart View 1 2 2 chunks +5 lines, -4 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/lib/io_patch.dart View 1 2 3 chunks +26 lines, -6 lines 0 comments Download
M sdk/lib/_internal/dartdoc/lib/dartdoc.dart View 1 2 4 chunks +27 lines, -23 lines 0 comments Download
D sdk/lib/io/chunked_stream.dart View 1 2 1 chunk +0 lines, -140 lines 0 comments Download
M sdk/lib/io/directory.dart View 1 2 3 chunks +13 lines, -54 lines 0 comments Download
M sdk/lib/io/directory_impl.dart View 1 2 3 chunks +51 lines, -84 lines 0 comments Download
M sdk/lib/io/file.dart View 1 2 2 chunks +21 lines, -17 lines 0 comments Download
M sdk/lib/io/file_impl.dart View 1 2 7 chunks +202 lines, -309 lines 0 comments Download
M sdk/lib/io/http.dart View 1 2 21 chunks +173 lines, -212 lines 0 comments Download
M sdk/lib/io/http_headers.dart View 1 2 6 chunks +94 lines, -4 lines 0 comments Download
M sdk/lib/io/http_impl.dart View 1 2 6 chunks +1165 lines, -1843 lines 0 comments Download
M sdk/lib/io/http_parser.dart View 1 2 15 chunks +326 lines, -148 lines 0 comments Download
M sdk/lib/io/http_session.dart View 1 2 5 chunks +29 lines, -13 lines 0 comments Download
M sdk/lib/io/input_stream.dart View 1 2 1 chunk +0 lines, -135 lines 0 comments Download
M sdk/lib/io/io.dart View 1 2 3 chunks +3 lines, -6 lines 0 comments Download
M sdk/lib/io/iolib_sources.gypi View 1 2 3 chunks +3 lines, -6 lines 0 comments Download
D sdk/lib/io/list_stream.dart View 1 2 1 chunk +0 lines, -57 lines 0 comments Download
D sdk/lib/io/list_stream_impl.dart View 1 2 1 chunk +0 lines, -161 lines 0 comments Download
M sdk/lib/io/process.dart View 1 2 4 chunks +4 lines, -4 lines 0 comments Download
M sdk/lib/io/secure_server_socket.dart View 1 2 1 chunk +195 lines, -60 lines 0 comments Download
M sdk/lib/io/secure_socket.dart View 1 2 9 chunks +414 lines, -353 lines 0 comments Download
M sdk/lib/io/socket.dart View 1 2 3 chunks +131 lines, -60 lines 0 comments Download
D sdk/lib/io/socket_stream_impl.dart View 1 2 1 chunk +0 lines, -232 lines 0 comments Download
M sdk/lib/io/stdio.dart View 1 2 4 chunks +23 lines, -15 lines 0 comments Download
D sdk/lib/io/stream_util.dart View 1 2 1 chunk +0 lines, -211 lines 0 comments Download
M sdk/lib/io/string_stream.dart View 1 2 1 chunk +0 lines, -589 lines 0 comments Download
M sdk/lib/io/websocket.dart View 1 2 6 chunks +18 lines, -162 lines 0 comments Download
M sdk/lib/io/websocket_impl.dart View 1 2 6 chunks +243 lines, -430 lines 0 comments Download
M sdk/lib/utf/utf.dart View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M tests/standalone/debugger/debug_lib.dart View 1 2 5 chunks +49 lines, -41 lines 0 comments Download
D tests/standalone/io/chunked_stream_test.dart View 1 2 1 chunk +0 lines, -140 lines 0 comments Download
M tests/standalone/io/dart_std_io_pipe_test.dart View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M tests/standalone/io/directory_error_test.dart View 1 2 2 chunks +13 lines, -5 lines 0 comments Download
M tests/standalone/io/directory_fuzz_test.dart View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M tests/standalone/io/directory_invalid_arguments_test.dart View 1 2 1 chunk +39 lines, -42 lines 0 comments Download
M tests/standalone/io/directory_test.dart View 1 2 5 chunks +47 lines, -95 lines 0 comments Download
M tests/standalone/io/echo_server_stream_test.dart View 1 2 3 chunks +38 lines, -80 lines 0 comments Download
D tests/standalone/io/echo_server_test.dart View 1 2 1 chunk +0 lines, -203 lines 0 comments Download
M tests/standalone/io/file_fuzz_test.dart View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M tests/standalone/io/file_input_stream_test.dart View 1 2 2 chunks +156 lines, -77 lines 0 comments Download
M tests/standalone/io/file_output_stream_test.dart View 1 2 1 chunk +5 lines, -75 lines 0 comments Download
M tests/standalone/io/file_system_links_test.dart View 1 2 5 chunks +45 lines, -30 lines 0 comments Download
M tests/standalone/io/file_test.dart View 1 2 8 chunks +147 lines, -246 lines 0 comments Download
M tests/standalone/io/http_advanced_test.dart View 1 2 13 chunks +194 lines, -246 lines 0 comments Download
M tests/standalone/io/http_auth_test.dart View 1 2 4 chunks +152 lines, -155 lines 0 comments Download
M tests/standalone/io/http_basic_test.dart View 1 2 10 chunks +100 lines, -93 lines 0 comments Download
M tests/standalone/io/http_client_test.dart View 1 2 4 chunks +31 lines, -42 lines 0 comments Download
M tests/standalone/io/http_connection_close_test.dart View 1 2 2 chunks +57 lines, -58 lines 0 comments Download
M tests/standalone/io/http_connection_header_test.dart View 1 2 2 chunks +40 lines, -41 lines 0 comments Download
M tests/standalone/io/http_connection_info_test.dart View 1 2 1 chunk +35 lines, -33 lines 0 comments Download
M tests/standalone/io/http_content_length_test.dart View 1 2 1 chunk +209 lines, -172 lines 0 comments Download
M tests/standalone/io/http_date_test.dart View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M tests/standalone/io/http_head_test.dart View 1 2 1 chunk +34 lines, -39 lines 0 comments Download
M tests/standalone/io/http_headers_state_test.dart View 1 2 2 chunks +63 lines, -63 lines 0 comments Download
M tests/standalone/io/http_headers_test.dart View 1 2 9 chunks +12 lines, -12 lines 0 comments Download
M tests/standalone/io/http_parser_test.dart View 1 2 26 chunks +166 lines, -150 lines 0 comments Download
M tests/standalone/io/http_proxy_test.dart View 1 2 6 chunks +236 lines, -223 lines 0 comments Download
M tests/standalone/io/http_read_test.dart View 1 2 8 chunks +72 lines, -131 lines 0 comments Download
M tests/standalone/io/http_redirect_test.dart View 1 2 1 chunk +322 lines, -338 lines 0 comments Download
M tests/standalone/io/http_server_early_client_close_test.dart View 1 2 4 chunks +67 lines, -57 lines 0 comments Download
M tests/standalone/io/http_server_early_server_close_test.dart View 1 2 1 chunk +23 lines, -24 lines 0 comments Download
D tests/standalone/io/http_server_handler_test.dart View 1 2 1 chunk +0 lines, -187 lines 0 comments Download
D tests/standalone/io/http_server_socket_test.dart View 1 2 1 chunk +0 lines, -237 lines 0 comments Download
M tests/standalone/io/http_server_test.dart View 1 2 2 chunks +39 lines, -42 lines 0 comments Download
M tests/standalone/io/http_session_test.dart View 1 2 2 chunks +117 lines, -69 lines 0 comments Download
M tests/standalone/io/http_shutdown_test.dart View 1 2 2 chunks +142 lines, -130 lines 0 comments Download
M tests/standalone/io/http_stream_close_test.dart View 1 2 1 chunk +38 lines, -39 lines 0 comments Download
M tests/standalone/io/https_client_certificate_test.dart View 1 2 3 chunks +27 lines, -71 lines 0 comments Download
M tests/standalone/io/https_client_test.dart View 1 2 1 chunk +24 lines, -28 lines 0 comments Download
M tests/standalone/io/https_server_test.dart View 1 2 1 chunk +36 lines, -42 lines 0 comments Download
D tests/standalone/io/list_input_stream_test.dart View 1 2 1 chunk +0 lines, -291 lines 0 comments Download
D tests/standalone/io/list_output_stream_test.dart View 1 2 1 chunk +0 lines, -173 lines 0 comments Download
M tests/standalone/io/mime_multipart_parser_test.dart View 1 2 1 chunk +6 lines, -1 line 0 comments Download
M tests/standalone/io/process_broken_pipe_test.dart View 1 2 2 chunks +9 lines, -7 lines 0 comments Download
M tests/standalone/io/process_check_arguments_test.dart View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M tests/standalone/io/process_exit_test.dart View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M tests/standalone/io/process_kill_test.dart View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M tests/standalone/io/process_segfault_test.dart View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M tests/standalone/io/process_set_exit_code_script.dart View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M tests/standalone/io/process_std_io_script.dart View 1 2 1 chunk +6 lines, -7 lines 0 comments Download
M tests/standalone/io/process_std_io_script2.dart View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M tests/standalone/io/process_stderr_test.dart View 1 2 2 chunks +7 lines, -9 lines 0 comments Download
M tests/standalone/io/process_stdout_test.dart View 1 2 2 chunks +7 lines, -9 lines 0 comments Download
M tests/standalone/io/process_working_directory_test.dart View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M tests/standalone/io/read_into_const_list_test.dart View 1 2 1 chunk +10 lines, -9 lines 0 comments Download
M tests/standalone/io/regress_6521_test.dart View 1 2 1 chunk +25 lines, -24 lines 0 comments Download
D tests/standalone/io/regress_7097_test.dart View 1 2 1 chunk +0 lines, -82 lines 0 comments Download
M tests/standalone/io/regress_7191_script.dart View 1 2 2 chunks +9 lines, -10 lines 0 comments Download
M tests/standalone/io/regress_7191_test.dart View 1 2 2 chunks +6 lines, -8 lines 0 comments Download
D tests/standalone/io/secure_builtin_roots_test.dart View 1 2 1 chunk +0 lines, -44 lines 0 comments Download
M tests/standalone/io/secure_no_builtin_roots_test.dart View 1 2 1 chunk +11 lines, -19 lines 0 comments Download
M tests/standalone/io/secure_server_client_certificate_test.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
D tests/standalone/io/secure_server_stream_test.dart View 1 2 1 chunk +0 lines, -101 lines 0 comments Download
D tests/standalone/io/secure_server_test.dart View 1 2 1 chunk +0 lines, -119 lines 0 comments Download
M tests/standalone/io/secure_session_resume_test.dart View 1 2 3 chunks +45 lines, -105 lines 0 comments Download
M tests/standalone/io/secure_socket_bad_certificate_test.dart View 1 2 3 chunks +28 lines, -41 lines 0 comments Download
M tests/standalone/io/secure_socket_test.dart View 1 2 1 chunk +17 lines, -45 lines 0 comments Download
D tests/standalone/io/secure_stream_test.dart View 1 2 1 chunk +0 lines, -36 lines 0 comments Download
M tests/standalone/io/socket_close_test.dart View 1 2 14 chunks +61 lines, -65 lines 0 comments Download
M tests/standalone/io/socket_exception_test.dart View 1 2 2 chunks +189 lines, -149 lines 0 comments Download
M tests/standalone/io/socket_info_test.dart View 1 2 1 chunk +13 lines, -12 lines 0 comments Download
M tests/standalone/io/socket_invalid_arguments_test.dart View 1 2 3 chunks +37 lines, -35 lines 0 comments Download
M tests/standalone/io/socket_many_connections_test.dart View 1 2 3 chunks +13 lines, -12 lines 0 comments Download
M tests/standalone/io/socket_port_test.dart View 1 2 1 chunk +11 lines, -12 lines 0 comments Download
D tests/standalone/io/socket_stream_close_test.dart View 1 2 1 chunk +0 lines, -418 lines 0 comments Download
M tests/standalone/io/stream_pipe_test.dart View 1 2 7 chunks +39 lines, -157 lines 0 comments Download
M tests/standalone/io/string_decoder_test.dart View 1 2 1 chunk +43 lines, -32 lines 0 comments Download
D tests/standalone/io/string_stream_test.dart View 1 2 1 chunk +0 lines, -335 lines 0 comments Download
M tests/standalone/io/testing_server.dart View 1 2 2 chunks +9 lines, -7 lines 0 comments Download
M tests/standalone/io/url_encoding_test.dart View 1 2 1 chunk +4 lines, -6 lines 0 comments Download
M tests/standalone/io/web_socket_no_secure_test.dart View 1 2 1 chunk +215 lines, -314 lines 0 comments Download
M tests/standalone/io/web_socket_protocol_processor_test.dart View 1 2 5 chunks +8 lines, -5 lines 0 comments Download
D tests/standalone/io/web_socket_secure_test.dart View 1 2 1 chunk +0 lines, -63 lines 0 comments Download
M tests/standalone/io/web_socket_test.dart View 1 2 1 chunk +215 lines, -316 lines 0 comments Download
M tests/standalone/standalone.status View 1 2 2 chunks +16 lines, -2 lines 0 comments Download
M tools/line_doc_comments.dart View 1 2 1 chunk +8 lines, -5 lines 0 comments Download
M utils/apidoc/apidoc.dart View 1 2 1 chunk +41 lines, -39 lines 0 comments Download
M utils/pub/http.dart View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M utils/pub/io.dart View 1 2 7 chunks +43 lines, -121 lines 0 comments Download
M utils/pub/oauth2.dart View 1 2 1 chunk +31 lines, -29 lines 0 comments Download
M utils/testrunner/utils.dart View 1 2 1 chunk +17 lines, -14 lines 0 comments Download
M utils/tests/pub/oauth2_test.dart View 1 2 8 chunks +13 lines, -13 lines 0 comments Download
M utils/tests/pub/pub_lish_test.dart View 1 2 14 chunks +29 lines, -29 lines 0 comments Download
M utils/tests/pub/pub_uploader_test.dart View 1 2 7 chunks +15 lines, -15 lines 0 comments Download
M utils/tests/pub/test_pub.dart View 1 2 9 chunks +55 lines, -55 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Søren Gjesse
7 years, 10 months ago (2013-02-21 10:22:26 UTC) #1
Mads Ager (google)
First tiny round of comments. I think we can clean up the status files some ...
7 years, 10 months ago (2013-02-21 10:26:49 UTC) #2
Mads Ager (google)
LGTM with a couple of changes to reduce the diff a tiny bit. https://codereview.chromium.org/12316036/diff/1/runtime/tests/vm/vm.status File ...
7 years, 10 months ago (2013-02-21 10:39:01 UTC) #3
Søren Gjesse
https://codereview.chromium.org/12316036/diff/1/runtime/tests/vm/vm.status File runtime/tests/vm/vm.status (right): https://codereview.chromium.org/12316036/diff/1/runtime/tests/vm/vm.status#newcode32 runtime/tests/vm/vm.status:32: [ $compiler == dart2js ] On 2013/02/21 10:39:02, Mads ...
7 years, 10 months ago (2013-02-21 11:44:25 UTC) #4
Søren Gjesse
7 years, 10 months ago (2013-02-21 11:59:38 UTC) #5
Message was sent while issue was closed. 
Committed patchset #3 manually as r18820 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698