Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(496)

Issue 12315097: Updated ddbg to use new streams API. (Closed)

Created:
7 years, 10 months ago by Tom Ball
Modified:
7 years, 10 months ago
Reviewers:
Søren Gjesse, hausner
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Updated ddbg to use new streams API. Committed: https://code.google.com/p/dart/source/detail?r=19086

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -31 lines) Patch
M tools/ddbg.dart View 1 5 chunks +25 lines, -31 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Tom Ball
Fixed ddbg.dart to work with new IO API. Søren, I don't know if you're the ...
7 years, 10 months ago (2013-02-26 01:05:16 UTC) #1
Tom Ball
One question/issue I found: I had to add an exit(0) to quitShell(), which previously wasn't ...
7 years, 10 months ago (2013-02-26 01:09:56 UTC) #2
Søren Gjesse
lgtm https://codereview.chromium.org/12315097/diff/1/tools/ddbg.dart File tools/ddbg.dart (right): https://codereview.chromium.org/12315097/diff/1/tools/ddbg.dart#newcode61 tools/ddbg.dart:61: exit(0); As you mentioned this looks wrong. What ...
7 years, 10 months ago (2013-02-26 15:40:04 UTC) #3
hausner
LGTM assuming it works. Might be good to do some one-off testing by making the ...
7 years, 10 months ago (2013-02-26 17:43:53 UTC) #4
Tom Ball
https://codereview.chromium.org/12315097/diff/1/tools/ddbg.dart File tools/ddbg.dart (right): https://codereview.chromium.org/12315097/diff/1/tools/ddbg.dart#newcode61 tools/ddbg.dart:61: exit(0); On 2013/02/26 15:40:04, Søren Gjesse wrote: > As ...
7 years, 10 months ago (2013-02-26 18:18:53 UTC) #5
Tom Ball
7 years, 10 months ago (2013-02-26 21:53:53 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 manually as r19086 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698