Updated ddbg to use new streams API.

tools/ddbg.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 // Simple interactive debugger shell that connects to the Dart VM's debugger
 // connection port.
 
 import "dart:io";
 import "dart:json" as json;
 import "dart:utf";
 import "dart:async";
 
 
 Map<int, Completer> outstandingCommands;
 
 Socket vmSock;
 String vmData;
-OutputStream vmStream;
+Stream stringStream;
 int seqNum = 0;
 int isolate_id = -1;
 
 bool verbose = false;
 
 // The current stack trace, while the VM is paused. It's a list
 // of activation frames.
 List stackTrace;
 
 // The current activation frame, while the VM is paused.
@@ skipping 20 matching lines @@
   ls <lib_id> List loaded scripts in library
   gs <lib_id> <script_url> Get source text of script in library
   epi <none|all|unhandled>  Set exception pause info
   i <id> Interrupt execution of given isolate id
   h   Print help
 """);
 }
 
 
 void quitShell() {
-  vmStream.close();
   vmSock.close();
-  stdin.close();
+  stdout.close();
+  exit(0);

[Søren Gjesse, 2013/02/26 15:40:04]

As you mentioned this looks wrong. What should work is to get the subscription
in the stringStream.listen below, and the cancel this subscription here.

However there is a bug in StringDecoder which was fixed in
https://code.google.com/p/dart/source/detail?r=19046, so make sure to use that
revision for trying it out.

[Tom Ball, 2013/02/26 18:18:54]

I made the change you suggested and sync'd to 19061, but the main isolate is
still waiting due to one remaining live port.  Any suggestions on how I can
debug which port/variable this is?

 }
 
 
 Future sendCmd(Map<String, dynamic> cmd) {
   var completer = new Completer();
   int id = cmd["id"];
   outstandingCommands[id] = completer;
   if (verbose) {
     print("sending: '${json.stringify(cmd)}'");
   }
-  vmStream.writeString(json.stringify(cmd));
+  vmSock.addString(json.stringify(cmd));
   return completer.future;
 }
 
 
 void processCommand(String cmdLine) {
   seqNum++;
   var args = cmdLine.split(' ');
   if (args.length == 0) {
     return;
   }
@@ skipping 438 matching lines @@
       // Strings can contain braces. Skip their content.
       index = skipString(index);
     }
   }
   return 0;
 }
 
 
 void debuggerMain() {
   outstandingCommands = new Map<int, Completer>();
-  vmSock = new Socket("127.0.0.1", 5858);
-  vmStream = vmSock.outputStream;
-  var stdinStream = new StringInputStream(stdin);
-  stdinStream.onLine = () {
-    processCommand(stdinStream.readLine());
-  };
-  var vmInStream = vmSock.inputStream;
-  vmInStream.onData = () {
-    String s = decodeUtf8(vmInStream.read());
-    processVmData(s);
-  };
-  vmInStream.onError = (err) {
-    print("Error in debug connection: $err");
-    quitShell();
-  };
-  vmInStream.onClosed = () {
-    print("VM debugger connection closed");
-    quitShell();
-  };
+  Socket.connect("127.0.0.1", 5858).then((s) {
+    vmSock = s;
+    stringStream = vmSock.transform(new StringDecoder());
+    stringStream.listen(
+        (String data) {
+          processVmData(data);
+        },
+        onDone: () {
+          print("VM debugger connection closed");
+          quitShell();
+        },
+        onError: (err) {
+          print("Error in debug connection: $err");
+          quitShell();
+        });
+    stdin.transform(new StringDecoder())
+        .transform(new LineTransformer())
+        .listen((String line) => processCommand(line));
+  });
 }
 
 void main() {
   Options options = new Options();
   List<String> arguments = options.arguments;
   if (arguments.length > 0) {
     arguments = <String>['--debug', '--verbose_debug']..addAll(arguments);
     Process.start(options.executable, arguments).then((Process process) {
-      process.onExit = (int exitCode) {
+      process.stdin.close();
+      process.exitCode.then((int exitCode) {
         print('${arguments.join(" ")} exited with $exitCode');
-      };
-      process.stdin.close();
-      // Redirecting both stdout and stderr of the child process to
-      // stdout.  This should help users keep track of which errors
-      // are coming from the debugger, and which errors are coming
-      // from the process being debugged.
-      process.stderr.pipe(stdout);
-      process.stdout.pipe(stdout);
+      });
       debuggerMain();
     });
   } else {
     debuggerMain();
   }
 }