Issue 12314148: Make sure the socket unsubscribes on error, so we don't get race conditions between an error and an…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12314148: Make sure the socket unsubscribes on error, so we don't get race conditions between an error and an… (Closed)

Created:
7 years, 9 months ago by Anders Johnsen

Modified:
7 years, 9 months ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Make sure the socket unsubscribes on error, so we don't get race conditions between an error and an immidiately following close event. This makes sure we always see the expected errors. BUG= Committed: https://code.google.com/p/dart/source/detail?r=19117

Patch Set 1 #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -13 lines)			Patch
	M	runtime/bin/socket_patch.dart	View		1 chunk	+15 lines, -13 lines	0 comments	Download
	M	sdk/lib/io/io_stream_consumer.dart	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Anders Johnsen

7 years, 9 months ago (2013-02-27 09:27:15 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r19117 (presubmit successful).

Expand Messages | Collapse Messages