Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Side by Side Diff: sdk/lib/io/io_stream_consumer.dart

Issue 12314148: Make sure the socket unsubscribes on error, so we don't get race conditions between an error and an… (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « runtime/bin/socket_patch.dart ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 part of dart.io; 5 part of dart.io;
6 6
7 /** 7 /**
8 * Helper class to wrap a [StreamConsumer<List<int>, T>] and provide utility 8 * Helper class to wrap a [StreamConsumer<List<int>, T>] and provide utility
9 * functions for writing to the StreamConsumer directly. The [IOSink] 9 * functions for writing to the StreamConsumer directly. The [IOSink]
10 * buffers the input given by [add] and [addString] and will delay a [consume] 10 * buffers the input given by [add] and [addString] and will delay a [consume]
(...skipping 140 matching lines...) Expand 10 before | Expand all | Expand 10 after
151 } else { 151 } else {
152 _controller.close(); 152 _controller.close();
153 } 153 }
154 }, 154 },
155 onError: _controller.signalError); 155 onError: _controller.signalError);
156 if (_paused) _pause(); 156 if (_paused) _pause();
157 if (unbind) { 157 if (unbind) {
158 _pipeFuture.catchError((error) { 158 _pipeFuture.catchError((error) {
159 if (unbindCompleter != null) { 159 if (unbindCompleter != null) {
160 unbindCompleter.completeError(error); 160 unbindCompleter.completeError(error);
161 unbindCompleter = null;
161 } 162 }
162 }); 163 });
163 return unbindCompleter.future; 164 return unbindCompleter.future;
164 } else { 165 } else {
165 return _pipeFuture; 166 return _pipeFuture;
166 } 167 }
167 } 168 }
168 } 169 }
OLDNEW
« no previous file with comments | « runtime/bin/socket_patch.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698