Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(371)

Issue 12314132: Fix bad optimization prematurely marking types as instantiated (issue 8710). (Closed)

Created:
7 years, 9 months ago by regis
Modified:
7 years, 9 months ago
Reviewers:
zra, srdjan
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix bad optimization prematurely marking types as instantiated (issue 8710). Add test. Committed: https://code.google.com/p/dart/source/detail?r=19101

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -21 lines) Patch
M runtime/vm/class_finalizer.cc View 1 2 chunks +2 lines, -6 lines 0 comments Download
M runtime/vm/object.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M runtime/vm/object.cc View 1 4 chunks +10 lines, -12 lines 0 comments Download
M runtime/vm/parser.cc View 1 1 chunk +1 line, -1 line 0 comments Download
A tests/language/generics3_test.dart View 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
regis
7 years, 9 months ago (2013-02-26 22:56:09 UTC) #1
srdjan
lgtm
7 years, 9 months ago (2013-02-27 00:24:40 UTC) #2
regis
7 years, 9 months ago (2013-02-27 00:32:37 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r19101 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698