runtime/vm/parser.cc - Issue 12314132: Fix bad optimization prematurely marking types as instantiated (issue 8710).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/parser.cc

Issue 12314132: Fix bad optimization prematurely marking types as instantiated (issue 8710). (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/parser.cc

===================================================================

--- runtime/vm/parser.cc (revision 19100)

+++ runtime/vm/parser.cc (working copy)

@@ -5105,7 +5105,7 @@

Type::Handle(Type::Function()).type_class());

function_type = Type::New(

unknown_signature_class, TypeArguments::Handle(), ident_pos);

- function_type.set_is_finalized_instantiated(); // No finalization needed.

+ function_type.SetIsFinalized(); // No finalization needed.

// Add the function variable to the scope before parsing the function in

// order to allow self reference from inside the function.

« no previous file with comments | « runtime/vm/object.cc ('k') | tests/language/generics3_test.dart » ('j') | no next file with comments »