Issue 12310133: Fix for issue 8781: it is not ok to move a HTypeGuard, so mark it as "unpure".

Issue 12310133: Fix for issue 8781: it is not ok to move a HTypeGuard, so mark it as "unpure". (Closed)

Created:
7 years, 10 months ago by ngeoffray

Modified:
7 years, 9 months ago

Reviewers:
kasperl

CC:
reviews_dartlang.org, Vyacheslav Egorov (Google)

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix for issue 8781: it is not ok to move a HTypeGuard, so mark it as "unpure". Committed: https://code.google.com/p/dart/source/detail?r=19110

Patch Set 2 : #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+55 lines, -0 lines)			Patch
	M	sdk/lib/_internal/compiler/implementation/ssa/nodes.dart	View	1	1 chunk	+6 lines, -0 lines	0 comments	Download
	A	tests/language/field_increment_bailout_test.dart	View		1 chunk	+49 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

kasperl

LGTM. https://codereview.chromium.org/12310133/diff/1/sdk/lib/_internal/compiler/implementation/ssa/nodes.dart File sdk/lib/_internal/compiler/implementation/ssa/nodes.dart (right): https://codereview.chromium.org/12310133/diff/1/sdk/lib/_internal/compiler/implementation/ssa/nodes.dart#newcode1219 sdk/lib/_internal/compiler/implementation/ssa/nodes.dart:1219: // A [HTypeGuard] cannot be moved anywhere in ...

7 years, 10 months ago (2013-02-26 17:36:48 UTC) #2

ngeoffray

Thanks Kasper. https://codereview.chromium.org/12310133/diff/1/sdk/lib/_internal/compiler/implementation/ssa/nodes.dart File sdk/lib/_internal/compiler/implementation/ssa/nodes.dart (right): https://codereview.chromium.org/12310133/diff/1/sdk/lib/_internal/compiler/implementation/ssa/nodes.dart#newcode1219 sdk/lib/_internal/compiler/implementation/ssa/nodes.dart:1219: // A [HTypeGuard] cannot be moved anywhere ...

7 years, 9 months ago (2013-02-27 08:06:54 UTC) #3

ngeoffray

7 years, 9 months ago (2013-02-27 08:07:12 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r19110 (presubmit successful).

Expand Messages | Collapse Messages