Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Unified Diff: sdk/lib/_internal/compiler/implementation/ssa/nodes.dart

Issue 12310133: Fix for issue 8781: it is not ok to move a HTypeGuard, so mark it as "unpure". (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tests/language/field_increment_bailout_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/_internal/compiler/implementation/ssa/nodes.dart
===================================================================
--- sdk/lib/_internal/compiler/implementation/ssa/nodes.dart (revision 19109)
+++ sdk/lib/_internal/compiler/implementation/ssa/nodes.dart (working copy)
@@ -1217,6 +1217,12 @@
bool isJsStatement() => isEnabled;
bool canThrow() => isEnabled;
+ // A [HTypeGuard] cannot be moved anywhere in the graph, otherwise
+ // instructions that have side effects could end up before the guard
+ // in the otpimized version, and after the guard in a bailout
+ // version.
+ bool isPure() => false;
+
accept(HVisitor visitor) => visitor.visitTypeGuard(this);
int typeCode() => HInstruction.TYPE_GUARD_TYPECODE;
bool typeEquals(other) => other is HTypeGuard;
« no previous file with comments | « no previous file | tests/language/field_increment_bailout_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698