Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issue 12301042: Implement ARM disassembler. (Closed)

Created:
7 years, 10 months ago by regis
Modified:
7 years, 10 months ago
Reviewers:
srdjan
CC:
reviews_dartlang.org, zra
Visibility:
Public.

Description

Implement ARM disassembler. Implement ARM call patcher. Committed: https://code.google.com/p/dart/source/detail?r=18769

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1307 lines, -70 lines) Patch
M runtime/tests/vm/vm.status View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/assembler_arm.cc View 1 2 3 3 chunks +3 lines, -3 lines 0 comments Download
M runtime/vm/disassembler_arm.cc View 1 2 3 2 chunks +1225 lines, -3 lines 0 comments Download
M runtime/vm/disassembler_test.cc View 1 2 3 1 chunk +6 lines, -4 lines 0 comments Download
M runtime/vm/instructions_arm.h View 1 2 3 2 chunks +11 lines, -39 lines 0 comments Download
M runtime/vm/instructions_arm.cc View 1 2 3 1 chunk +55 lines, -18 lines 0 comments Download
M runtime/vm/instructions_arm_test.cc View 1 2 3 1 chunk +3 lines, -2 lines 0 comments Download
M runtime/vm/object.h View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
regis
7 years, 10 months ago (2013-02-20 00:49:36 UTC) #1
srdjan
lgtm
7 years, 10 months ago (2013-02-20 17:00:32 UTC) #2
regis
7 years, 10 months ago (2013-02-20 17:28:42 UTC) #3
Message was sent while issue was closed.
Committed patchset #4 manually as r18769 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698