Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(887)

Unified Diff: runtime/vm/assembler_arm.cc

Issue 12301042: Implement ARM disassembler. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/tests/vm/vm.status ('k') | runtime/vm/disassembler_arm.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/assembler_arm.cc
===================================================================
--- runtime/vm/assembler_arm.cc (revision 18767)
+++ runtime/vm/assembler_arm.cc (working copy)
@@ -1176,7 +1176,7 @@
void Assembler::BranchLinkPatchable(const ExternalLabel* label) {
- // TODO(regis): Make sure that CodePatcher is able to patch the label referred
+ // Make sure that class CallPattern is able to patch the label referred
// to by this code sequence.
// For added code robustness, use 'blx lr' in a patchable sequence and
// use 'blx ip' in a non-patchable sequence (see other BranchLink flavors).
@@ -1557,7 +1557,7 @@
}
}
object_pool_.Add(obj);
- return object_pool_.Length();
+ return object_pool_.Length() - 1;
}
@@ -1574,7 +1574,7 @@
// Do not reuse an existing entry, since each reference may be patched
// independently.
object_pool_.Add(smi);
- return object_pool_.Length();
+ return object_pool_.Length() - 1;
}
} // namespace dart
« no previous file with comments | « runtime/tests/vm/vm.status ('k') | runtime/vm/disassembler_arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698