Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issue 1230063010: Test tracing of string allocations (Closed)

Created:
5 years, 5 months ago by Cutch
Modified:
5 years, 5 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Test tracing of string allocations Also, fix a bug in string allocation tracing. R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/4da11ef37f69088456703f7ab3e22be7cb69f34e

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+167 lines, -3 lines) Patch
M runtime/vm/intrinsifier_arm.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/intrinsifier_arm64.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/intrinsifier_ia32.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/intrinsifier_mips.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/intrinsifier_x64.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/profiler_test.cc View 1 1 chunk +162 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Cutch
5 years, 5 months ago (2015-07-10 21:08:44 UTC) #2
rmacnak
LGTM
5 years, 5 months ago (2015-07-10 21:29:48 UTC) #3
Cutch
5 years, 5 months ago (2015-07-10 21:30:09 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
4da11ef37f69088456703f7ab3e22be7cb69f34e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698