runtime/vm/intrinsifier_mips.cc - Issue 1230063010: Test tracing of string allocations

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/intrinsifier_mips.cc

Issue 1230063010: Test tracing of string allocations (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/intrinsifier_mips.cc

diff --git a/runtime/vm/intrinsifier_mips.cc b/runtime/vm/intrinsifier_mips.cc

index cff0b62aaddc8d90170ba093f14298ed716dda32..1cbb12f5bca1a6cd8148f292a4c1929b23adcfe3 100644

--- a/runtime/vm/intrinsifier_mips.cc

+++ b/runtime/vm/intrinsifier_mips.cc

@@ -1883,7 +1883,7 @@ static void TryAllocateOnebyteString(Assembler* assembler,

Label* ok,

Label* failure) {

const Register length_reg = T2;

+ __ MaybeTraceAllocation(kOneByteStringCid, V0, failure);

__ mov(T6, length_reg); // Save the length register.

// TODO(koda): Protect against negative length and overflow here.

__ SmiUntag(length_reg);

« no previous file with comments | « runtime/vm/intrinsifier_ia32.cc ('k') | runtime/vm/intrinsifier_x64.cc » ('j') | no next file with comments »