Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1229673006: Generated source mapping through CPS. (Closed)

Created:
5 years, 5 months ago by Johnni Winther
Modified:
5 years, 5 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Cleanup #

Total comments: 4

Patch Set 3 : Updated cf. comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+516 lines, -182 lines) Patch
M pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart View 18 chunks +82 lines, -48 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart View 35 chunks +120 lines, -46 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart View 10 chunks +25 lines, -10 lines 0 comments Download
M pkg/compiler/lib/src/helpers/helpers.dart View 1 2 1 chunk +49 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/io/position_information.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/io/source_information.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/io/start_end_information.dart View 1 chunk +4 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/codegen/codegen.dart View 11 chunks +41 lines, -22 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder.dart View 2 chunks +4 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/tree_ir/optimization/statement_rewriter.dart View 2 chunks +6 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/tree_ir/tree_ir_builder.dart View 7 chunks +20 lines, -11 lines 0 comments Download
M pkg/compiler/lib/src/tree_ir/tree_ir_nodes.dart View 10 chunks +30 lines, -9 lines 0 comments Download
M tests/compiler/dart2js/sourcemaps/invokes_test_file.dart View 1 chunk +1 line, -0 lines 0 comments Download
M tests/compiler/dart2js/sourcemaps/source_mapping_test.dart View 2 chunks +119 lines, -26 lines 0 comments Download
M tests/compiler/dart2js/sourcemaps/sourcemap_helper.dart View 1 2 chunks +8 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Johnni Winther
5 years, 5 months ago (2015-07-10 12:16:29 UTC) #2
karlklose
LGTM. Please split code that is not related to selecting a subset of tests from ...
5 years, 5 months ago (2015-07-10 12:44:40 UTC) #3
Johnni Winther
https://codereview.chromium.org/1229673006/diff/20001/pkg/compiler/lib/src/helpers/helpers.dart File pkg/compiler/lib/src/helpers/helpers.dart (right): https://codereview.chromium.org/1229673006/diff/20001/pkg/compiler/lib/src/helpers/helpers.dart#newcode97 pkg/compiler/lib/src/helpers/helpers.dart:97: /// Set of tracked objects used by [track] and ...
5 years, 5 months ago (2015-07-10 13:26:38 UTC) #4
Johnni Winther
5 years, 5 months ago (2015-07-10 13:32:45 UTC) #5
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
73572dc3f15c75e41456eff155ebd4dc5b505506 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698