Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Unified Diff: pkg/compiler/lib/src/ssa/builder.dart

Issue 1229673006: Generated source mapping through CPS. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Updated cf. comments. Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/ssa/builder.dart
diff --git a/pkg/compiler/lib/src/ssa/builder.dart b/pkg/compiler/lib/src/ssa/builder.dart
index f866a0ff989f46e37a7c7f899aa2f7f93147f9cc..e00d7b785e2ff6735f9618bad257a16090eb4e6f 100644
--- a/pkg/compiler/lib/src/ssa/builder.dart
+++ b/pkg/compiler/lib/src/ssa/builder.dart
@@ -2191,8 +2191,10 @@ class SsaBuilder extends ast.Visitor
constructorArguments,
instantiatedTypes);
if (function != null) {
+ // TODO(johnniwinther): Provide source information for creation
+ // through synthetic constructors.
newObject.sourceInformation =
- sourceInformationBuilder.buildGeneric(function);
+ sourceInformationBuilder.buildCreate(function);
}
add(newObject);
} else {
@@ -3147,7 +3149,7 @@ class SsaBuilder extends ast.Visitor
TypeMask type =
new TypeMask.nonNullExact(compiler.functionClass, compiler.world);
push(new HForeignNew(closureClassElement, type, capturedVariables)
- ..sourceInformation = sourceInformationBuilder.buildGeneric(node));
+ ..sourceInformation = sourceInformationBuilder.buildCreate(node));
Element methodElement = nestedClosureData.closureElement;
registry.registerInstantiatedClosure(methodElement);

Powered by Google App Engine
This is Rietveld 408576698