Issue 1229303004: Fix a stack overflow when loading transformers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1229303004: Fix a stack overflow when loading transformers. (Closed)

Created:
5 years, 5 months ago by nweiz

Modified:
5 years, 5 months ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/pub.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Fix a stack overflow when loading transformers. If a package used two instances of its own transformer on the transformer's own file (or a file it imported), the dependency computer would crash. Closes #1298 R=rnystrom@google.com Committed: https://github.com/dart-lang/pub/commit/62ffa7bde91d22ae8669d3db779856bcbb25cc5d

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -2 lines)			Patch
	M	lib/src/barback/dependency_computer.dart	View		1 chunk	+2 lines, -2 lines	0 comments	Download
	M	test/dependency_computer/cycle_test.dart	View		1 chunk	+18 lines, -0 lines	0 comments	Download

Total messages: 4 (0 generated)

nweiz

On 2015/07/13 23:42:11, nweiz wrote: It looks like this may not have properly sent an ...

5 years, 5 months ago (2015-07-14 00:49:23 UTC) #2

nweiz

5 years, 5 months ago (2015-07-14 19:55:21 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
62ffa7bde91d22ae8669d3db779856bcbb25cc5d (presubmit successful).